Added support for optional DEGREE position in "FEELS" label#2395
Merged
MichMich merged 2 commits intoMagicMirrorOrg:developfrom Dec 31, 2020
Merged
Added support for optional DEGREE position in "FEELS" label#2395MichMich merged 2 commits intoMagicMirrorOrg:developfrom
MichMich merged 2 commits intoMagicMirrorOrg:developfrom
Conversation
Collaborator
|
Please revert @MichMich or please @ashishtank fix this issue that got introduced: Using the weather (and not the currentweather-) module the translation looks like this:
Porblem is both modules use the same translation but not the same logic (weaather is doing it in NJK file) |
Contributor
Author
|
@rejas let me check |
Contributor
Author
Contributor
Author
|
Looks like in our custom translate filter we do not have provision to pass key and values ? |
Collaborator
|
Indeed. So maybe add some params to it like the filters in weather.js have? |
Contributor
Author
|
Yes, I have solved it.. doing final testing. |
Collaborator
|
Ah. I’ll wait revering it. |
Collaborator
|
*reverting |
Contributor
Author
|
Finally solved it #2397, sending updated PR. Also added support for placeholder values for translate in nunjucks translate filter. English Gujarati |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some languages the value (number) should be first and then sentence. Added support for Degree label so it shows correct translation for Hindi and Gujarati with degree label at first and not at last.