Permit substituting a falsy value in translator variables#2393
Merged
MichMich merged 2 commits intoMagicMirrorOrg:developfrom Dec 31, 2020
Merged
Permit substituting a falsy value in translator variables#2393MichMich merged 2 commits intoMagicMirrorOrg:developfrom
MichMich merged 2 commits intoMagicMirrorOrg:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2389; this no longer evaluates the provided value, merely the presence of the key. That means values which are falsy to JS (empty string, undefined, number 0, etc.) now get substituted where before they didn't.
For some possible values, it's possible that's not what you wanted -- but leaving {VARNAME} in place probably wasn't either, so 🤷♂️. It fails differently now. For empty strings, zeros, etc. this fixes a bug.