Skip to content

Add new log level "debug"#2184

Merged
MichMich merged 2 commits intoMagicMirrorOrg:developfrom
rejas:debug_log_level
Nov 6, 2020
Merged

Add new log level "debug"#2184
MichMich merged 2 commits intoMagicMirrorOrg:developfrom
rejas:debug_log_level

Conversation

@rejas
Copy link
Collaborator

@rejas rejas commented Nov 6, 2020

Added a new log level for usage during development.

Can be used in https://github.com/MichMich/MagicMirror/pull/2178/files# so that no debug flags need to be when logging during development.

@MichMich MichMich merged commit 262711a into MagicMirrorOrg:develop Nov 6, 2020
@rejas rejas deleted the debug_log_level branch November 15, 2020 21:12
@khassel
Copy link
Collaborator

khassel commented Dec 28, 2020

With the change of

logLevel: ["DEBUG", "INFO", "LOG", "WARN", "ERROR"],

in the config.sample.js now everybody using this sample as starting config has DEBUG enabled. This is also the default, if logLevel is not set.

@rejas Was this intended?

@rejas
Copy link
Collaborator Author

rejas commented Dec 29, 2020

@khassel not really... PR incoming :-)

@rejas
Copy link
Collaborator Author

rejas commented Dec 29, 2020

the question would be @MichMich @sdetweil @khassel what log level would be sufficient for the sample? Dont want to spam too much noise but dont want to miss too much. info? log? warn?

@khassel
Copy link
Collaborator

khassel commented Dec 29, 2020

for me the "old" config with logLevel: ["INFO", "LOG", "WARN", "ERROR"], would be o.k.

@rejas rejas mentioned this pull request Dec 29, 2020
@sdetweil
Copy link
Collaborator

correct don't need debug in the sample as default setting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants