Fix calendar subsequent fetch timing with multiple calendar entries#2162
Merged
MichMich merged 6 commits intoMagicMirrorOrg:developfrom Oct 13, 2020
sdetweil:fixfetch
Merged
Fix calendar subsequent fetch timing with multiple calendar entries#2162MichMich merged 6 commits intoMagicMirrorOrg:developfrom sdetweil:fixfetch
MichMich merged 6 commits intoMagicMirrorOrg:developfrom
sdetweil:fixfetch
Conversation
rejas
reviewed
Oct 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when multiple calendars are configured, subsequent fetches only fetch the last entry in the array #2160
moves setInterval hander to inside addCalendar() and changes to setTimeout calling same routine
parameters are non-volatile