Fixes the un-hide problem with currentwether and weatherforcast modules.#2161
Merged
MichMich merged 3 commits intoMagicMirrorOrg:developfrom Oct 13, 2020
Snille:develop
Merged
Fixes the un-hide problem with currentwether and weatherforcast modules.#2161MichMich merged 3 commits intoMagicMirrorOrg:developfrom Snille:develop
MichMich merged 3 commits intoMagicMirrorOrg:developfrom
Snille:develop
Conversation
When this module is hidden from another module, it un-hides itself when it updates itself. With this change it stays hidden, as it should. :)
When this module is hidden from another module, it un-hides itself when it updates itself. With this change it stays hidden, as it should. :)
Added the "currentwather" and "watherforcast" update show fixes information.
Snille
changed the title
ghost
reviewed
Oct 12, 2020
Collaborator
|
This PR got reverted due to an issue: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does the pull request solve a related issue?
I don't really know if there is an "issue" created. I just read three different threads in the forum regarding the "automatic un-hide". And I have myself had the same problem.
What does the pull request accomplish? Use a list if needed.
Gets rid of the problem that you never can hide the "currentweather" and "weatherforcast" for more then the time it updates.
If it includes major visual changes please add screenshots.
No visual changes. Just piece of mind. :)