Update plugins contributions documentation#97
Merged
MaddyGuthridge merged 3 commits intoMaddyGuthridge:mainfrom Feb 27, 2023
Merged
Update plugins contributions documentation#97MaddyGuthridge merged 3 commits intoMaddyGuthridge:mainfrom
MaddyGuthridge merged 3 commits intoMaddyGuthridge:mainfrom
Conversation
added context for "plugins" to hopefully mitigate confusion at top of page added elaboration to the "basicPluginBuilder" example above to make really clear added the word binding to plugin with a few of the headers - I can see this being unnecessary at this point attempted to elaborate the "creating a plugin binding: the hard way" section to the best of my knowledge, I suspect this is not entirely correct. I've added some more specific and clear examples of some of the things being mentioned, as well as links to appropriate resources that will aid in providing the correct arguments. also added link to "Control Surfaces" in the control binding section for more relevant resources when coding a binding added a little more text to the Example Plugin section, trying to make it a bit easier to follow
MaddyGuthridge
requested changes
Feb 13, 2023
Owner
MaddyGuthridge
left a comment
MaddyGuthridge
left a comment
There was a problem hiding this comment.
Looking pretty good, but there are a few improvements that I'd like to see before it gets merged. Thanks for your work so far!
MaddyGuthridge
changed the title
MaddyGuthridge
approved these changes
Feb 27, 2023
Owner
MaddyGuthridge
left a comment
MaddyGuthridge
left a comment
There was a problem hiding this comment.
Fixed all the issues! Thanks so much for your contributions!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added context for "plugins" to hopefully mitigate confusion at top of page
added elaboration to the "basicPluginBuilder" example above to make really clear
added the word binding to plugin with a few of the headers - I can see this being unnecessary at this point
attempted to elaborate the "creating a plugin binding: the hard way" section to the best of my knowledge, I suspect this is not entirely correct. I've added some more specific and clear examples of some of the things being mentioned, as well as links to appropriate resources that will aid in providing the correct arguments.
also added link to "Control Surfaces" in the control binding section for more relevant resources when coding a binding
added a little more text to the Example Plugin section, trying to make it a bit easier to follow