Fixed #945 Cancel search mode while the search field is empty#946
Merged
mstarke merged 1 commit intoMacPass:masterfrom Oct 30, 2019
Merged
Fixed #945 Cancel search mode while the search field is empty#946mstarke merged 1 commit intoMacPass:masterfrom
mstarke merged 1 commit intoMacPass:masterfrom
Conversation
Member
|
Cancel is called when pressing escape (or am I wrong?) which exits search already. Pressing delete is send as deleteBackwards: but this will should be tested if the deletion will remove all the text. I did experiment a bit but the solution to this problem seem simple but might not be. I also am a bit confused, Finder works exactly like MacPass when an empty search string is givne (no search results). Mail on the other hand exits the search but keeps the focus on the search field. |
Member
|
@buddax2 Do you have any plans on updating you PR?� Otherwise I will try to look into this and fine a wholesome solution. |
mstarke
approved these changes
Oct 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.