Skip to content

Fixed #945 Cancel search mode while the search field is empty#946

Merged
mstarke merged 1 commit intoMacPass:masterfrom
buddax2:search-cancelation
Oct 30, 2019
Merged

Fixed #945 Cancel search mode while the search field is empty#946
mstarke merged 1 commit intoMacPass:masterfrom
buddax2:search-cancelation

Conversation

@buddax2
Copy link
Copy Markdown
Contributor

@buddax2 buddax2 commented Jun 26, 2019

No description provided.

@mstarke
Copy link
Copy Markdown
Member

mstarke commented Jul 12, 2019

Cancel is called when pressing escape (or am I wrong?) which exits search already. Pressing delete is send as deleteBackwards: but this will should be tested if the deletion will remove all the text. I did experiment a bit but the solution to this problem seem simple but might not be.

I also am a bit confused, Finder works exactly like MacPass when an empty search string is givne (no search results). Mail on the other hand exits the search but keeps the focus on the search field.

@mstarke
Copy link
Copy Markdown
Member

mstarke commented Jul 19, 2019

@buddax2 Do you have any plans on updating you PR?� Otherwise I will try to look into this and fine a wholesome solution.

@mstarke mstarke merged commit 631741d into MacPass:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants