Skip to content

Make keyfile selection window modal#898

Merged
mstarke merged 1 commit intoMacPass:masterfrom
denizt:keyfile-modal
Apr 5, 2019
Merged

Make keyfile selection window modal#898
mstarke merged 1 commit intoMacPass:masterfrom
denizt:keyfile-modal

Conversation

@denizt
Copy link
Copy Markdown
Contributor

@denizt denizt commented Mar 26, 2019

If we don't use the modal view, the user can put the file selection window to background, click 'Choose...' and open additional windows.

This can become confusing and the additional windows can stay there hanging through the app's lifecycle. Moreover, if we choose 'Choose...' from the drop down menu, after selecting a key file, the dialog displayed is currently modal, inline with this commit.

If we don't use the modal view, the user can put the file selection
window to background, click 'Choose...' and open additional windows.
@denizt
Copy link
Copy Markdown
Contributor Author

denizt commented Mar 27, 2019

This is indeed better, thanks!

I also had a look if it would be straightforward to make the second path the same, as it calls runModal -- after choosing a file, if you click the path again leading to keyPathControl -> NSPathControl -> [NSPathCell _otherItemClick]. I couldn't find a quick and clean way, if I am not mistaken, it would require customising the cell via NSPathCellDelegate?

@mstarke
Copy link
Copy Markdown
Member

mstarke commented Mar 27, 2019

I'm not sure I get what you mean by "make the second path the same" When you re-click the item selected, PathControl runs a modal panel. Mh. I'm not a big fan of having to use private APIs and while playing around with NSPathControl I found it rather rigid. But if you can get it to work, I'm ok with it. The other solution is to use your first version and just stick to a modal panel to make the UI consistent. Another idea would be to change the UI to use a drop-down and populate it with recent keys like other clients do it.

@denizt
Copy link
Copy Markdown
Contributor Author

denizt commented Mar 27, 2019

I think best way forward, for the time being, would be to use the first version with modal dialog, making things consistent and look at alternatives like populated drop-down down the road.

@mstarke
Copy link
Copy Markdown
Member

mstarke commented Mar 27, 2019

Sounds good and sorry for the stirr up but a sheet looks so much nicer :)

@denizt
Copy link
Copy Markdown
Contributor Author

denizt commented Mar 28, 2019

I agree the sheet is so much nicer and should be the end goal 😄 I reverted it back to the original commit.

@mstarke mstarke merged commit ae4656c into MacPass:master Apr 5, 2019
@mstarke mstarke added this to the 0.7.10 milestone Apr 5, 2019
@denizt denizt deleted the keyfile-modal branch October 28, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants