Skip to content

Update zh-hans localization#1179

Merged
mstarke merged 3 commits intoMacPass:masterfrom
skyline75489:chesterliu/zh-hans-loc-1
Dec 3, 2021
Merged

Update zh-hans localization#1179
mstarke merged 3 commits intoMacPass:masterfrom
skyline75489:chesterliu/zh-hans-loc-1

Conversation

@skyline75489
Copy link
Copy Markdown
Contributor

No description provided.

@skyline75489
Copy link
Copy Markdown
Contributor Author

I noticed that some entries are not in the xliff file, for example FAVICON_DOWNLOAD_METHOD_DIRECT, is this expected? I would love to also add translations for those entries.

@skyline75489
Copy link
Copy Markdown
Contributor Author

@mstarke friendly ping for PR

@mstarke
Copy link
Copy Markdown
Member

mstarke commented Nov 12, 2021

I've just pushed 1e78d3b which adds two views in need for localizations. Additionally there have been more changes to other strings. Would you be so kind and try to update your P? If you're done I'm going to merge it ASAP.

@skyline75489
Copy link
Copy Markdown
Contributor Author

I think I can handle most the TOTP related strings, but I don't what you mean by "more changes to other strings" specifically. Can you point it out so that I can modify the localization strings accordingly?

@mstarke
Copy link
Copy Markdown
Member

mstarke commented Nov 23, 2021

Other strings relates to the "Localizeable.strings" files, since there are a couple of additions and changes in other places besides .xib files.

@skyline75489
Copy link
Copy Markdown
Contributor Author

I think this is ready. The OTOP feature looks amazing, btw.

@mstarke mstarke merged commit 59c37e6 into MacPass:master Dec 3, 2021
@mstarke
Copy link
Copy Markdown
Member

mstarke commented Dec 3, 2021

Thank you very much for the support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants