fixed autofill on big sur for password field#1125
Merged
mstarke merged 2 commits intoMacPass:masterfrom Jun 17, 2021
Merged
Conversation
Member
|
One time code smells but it seems to do the trick. Might it be possible to use None as the content type? Or is this hard-coded into NSSecureTextField? |
Contributor
Author
|
I know it stinks, I hate it too. I believe "None" is the default content type, as that's what shows up in the attributes inspector in XCode before my change and it shows the offending behavior. I'm not a mac developer so I don't know where to look up all of NSSecureTextField's attributes... maybe there is an autofill kill switch there. |
|
It would be nice to see this change in an update, as this is bothering the heck out of me (feels like I have to 'fight' this popup all the time when trying to add a new entry) |
|
Any idea when it will be in production? :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apple enabled password autofill by default on Big Sur for NSSecureTextField.
This means that by clicking the password field in an entry in MacPass, an annoying "Passwords..." tooltip pops up.
By changing the secure text field's content type to "oneTimeCode", the default behavior is overridden and the autofill feature is disabled.