Merged
Conversation
由于 Apple 官方近年来对 Carbon 这种旧版框架的网页文档进行了归档或移除,最权威的查阅方式是通过 Apple 开源镜像或本地 Xcode 头文件。
Contributor
There was a problem hiding this comment.
Hey - 我在这里给出了一些高层次的反馈:
- 请考虑将 MacOS Controller 的 URL 从
master分支切换为指向特定提交的永久链接,这样即使 SDK 仓库发生变化,被引用的按键码定义也能保持稳定。 - 为了在不同语言之间保持一致性,请确保在 zh_cn 文档中对应的章节中也清晰地添加同一个 MacOS Controller 按键码引用。
给 AI 代理的提示
Please address the comments from this code review:
## Overall Comments
- Consider switching the MacOS Controller URL from the `master` branch to a specific commit permalink so the referenced keycode definitions remain stable even if the SDK repo changes.
- For consistency between languages, ensure the same MacOS Controller keycode reference is also clearly added to the corresponding section in the zh_cn documentation.帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈来改进后续的评审。
Original comment in English
Hey - I've left some high level feedback:
- Consider switching the MacOS Controller URL from the
masterbranch to a specific commit permalink so the referenced keycode definitions remain stable even if the SDK repo changes. - For consistency between languages, ensure the same MacOS Controller keycode reference is also clearly added to the corresponding section in the zh_cn documentation.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider switching the MacOS Controller URL from the `master` branch to a specific commit permalink so the referenced keycode definitions remain stable even if the SDK repo changes.
- For consistency between languages, ensure the same MacOS Controller keycode reference is also clearly added to the corresponding section in the zh_cn documentation.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
|
看起来没问题 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
先前macos控制器实现时, 曾经使用Carbon的定义进行键盘输入模拟 ,后续改换成 CGEventKeyboardSetUnicodeString e730b05
现将定义MacOS键码头文件链接附在文档中。
之所以是个第三方的SDK镜像是因为苹果貌似把Carbon的网页文档给删了,引导用户自己去看本地头文件,这里的文档链接只能找了个第三方sdk源,鉴于这个文件已经十几年未变并且在将来多半也不会变就这样吧。
由 Sourcery 提供的摘要
文档:
Original summary in English
Summary by Sourcery
Documentation: