Conversation
Contributor
There was a problem hiding this comment.
嗨——我已经审查了你的修改,看起来非常棒!
帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈来改进后续的评审。
Original comment in English
Hey - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the English ProjectInterface V2 documentation to explicitly specify how option applicability constraints (option.controller / option.resource) affect pipeline_override merging, including nested options and options referenced from different levels.
Changes:
- Added PI version note for v2.3.1 documenting the clarified “inactive option” filtering behavior.
- Clarified in multiple option-related sections that inapplicable options must not contribute any
pipeline_override(including nestedoption.option). - Documented that
global_option-referenced options still must satisfy their own controller/resource constraints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1168
Summary by Sourcery
澄清 Project Interface v2.3.1 文档中,controller/resource 适用性约束如何影响选项激活以及
pipeline_override合并行为。Documentation:
pipeline_override做出任何贡献;这一规则同样适用于嵌套选项以及从 resource/controller/global 选项中引用的选项。pipeline_override行为。Original summary in English
Summary by Sourcery
Clarify how controller/resource applicability constraints affect option activation and pipeline_override merging in the Project Interface v2.3.1 documentation.
Documentation: