Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - 我在这里给出了一些高层次的反馈：
- 由于在普通流程和 ADB 流程中都存在
SceneCommon.json，而本 PR 的目标是让它们保持一致，建议将共享配置抽取为单一来源（或一个有清晰引用的基类），以降低未来在 ADB 相关退出行为上产生差异的风险。 - 请再次确认 ADB 控制器的关闭/退出标志和回调在
Interface/Scene.json与两个SceneManager/SceneCommon.json文件之间的命名和结构是否保持一致，以便今后对退出逻辑的任何修改都能以相同方式影响这三份配置。
给 AI Agents 的提示
Please address the comments from this code review:
## Overall Comments
- Since `SceneCommon.json` exists in both the normal and ADB pipelines and this PR aims to keep them aligned, consider factoring the shared configuration into a single source (or a clearly referenced base) to reduce the risk of future divergence in ADB-related exit behavior.
- Double-check that the ADB controller shutdown/exit flags and callbacks are named and structured consistently across `Interface/Scene.json` and both `SceneManager/SceneCommon.json` files so that any future changes to the exit logic affect all three configurations in the same way.帮我变得更有用！请在每条评论上点 👍 或 👎，我会根据你的反馈来改进之后的代码审查。
Original comment in English
Hey - I've left some high level feedback:
- Since
SceneCommon.jsonexists in both the normal and ADB pipelines and this PR aims to keep them aligned, consider factoring the shared configuration into a single source (or a clearly referenced base) to reduce the risk of future divergence in ADB-related exit behavior. - Double-check that the ADB controller shutdown/exit flags and callbacks are named and structured consistently across
Interface/Scene.jsonand bothSceneManager/SceneCommon.jsonfiles so that any future changes to the exit logic affect all three configurations in the same way.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since `SceneCommon.json` exists in both the normal and ADB pipelines and this PR aims to keep them aligned, consider factoring the shared configuration into a single source (or a clearly referenced base) to reduce the risk of future divergence in ADB-related exit behavior.
- Double-check that the ADB controller shutdown/exit flags and callbacks are named and structured consistently across `Interface/Scene.json` and both `SceneManager/SceneCommon.json` files so that any future changes to the exit logic affect all three configurations in the same way.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Closed
Contributor
There was a problem hiding this comment.
Pull request overview
该 PR 旨在修正“关闭 ADB 控制器导致出现退出游戏弹窗”时，SceneManager/Interface 在退出与返回链路上的行为不一致问题，以避免场景跳转链异常中断或退出逻辑错误。
Changes:
- 调整 SceneManager 公共节点
__ScenePrivateCloseADBExit的识别/点击逻辑。 - 更新 Interface 的
SceneAnyEnterWorld.next中对__ScenePrivateCloseADBExit的调用方式以对齐行为。 - 为 ADB 资源补充
__ScenePrivateCloseADBExit节点定义。
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| assets/resource/pipeline/SceneManager/SceneCommon.json | 调整关闭 ADB 相关退出弹窗节点的识别与点击参数 |
| assets/resource/pipeline/Interface/Scene.json | 修改 SceneAnyEnterWorld 的 next 链路，变更对关闭 ADB 退出节点的调用方式 |
| assets/resource_adb/pipeline/SceneManager/SceneCommon.json | ADB 资源下新增 __ScenePrivateCloseADBExit 节点以对齐标准资源 |
zmdyy0318
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
由 Sourcery 提供的摘要
在共享和 ADB 专用流水线中，统一在关闭 ADB 控制器时场景管理器的退出行为。
Bug 修复：
增强：
Original summary in English
Summary by Sourcery
Align scene manager exit behavior when closing the ADB controller across shared and ADB-specific pipelines.
Bug Fixes:
Enhancements:
Bug 修复：
增强：
Original summary in English
由 Sourcery 提供的摘要
在共享和 ADB 专用流水线中，统一在关闭 ADB 控制器时场景管理器的退出行为。
Bug 修复：
增强：
Original summary in English
Summary by Sourcery
Align scene manager exit behavior when closing the ADB controller across shared and ADB-specific pipelines.
Bug Fixes:
Enhancements: