feat(SellProduct): 通过 maa-pipeline-generate 生成相关节点#1835
Merged
Conversation
Contributor
There was a problem hiding this comment.
Hey - 我已经审查了你的修改,看起来非常棒!
帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈改进后续评审。
Original comment in English
Hey - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
There was a problem hiding this comment.
Pull request overview
该 PR 将 SellProduct 相关 task 节点改为通过 maa-pipeline-generate 的数据驱动方式生成,减少按区域手写/复制的模板内容,并同步更新生成产物。
Changes:
- 将
task-template.jsonc中的区域开关从固定枚举改为${RegionPrefix}+${SellOptions}的通用模板。 - 调整
data.mjs导出结构,新增按区域聚合的SellOptions数据,供模板生成区域下的售卖点选项列表。 - 更新
task-config.json与生成后的assets/tasks/SellProduct.json产物内容(格式/注释/去重等)。
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tools/pipeline-generate/SellProduct/task-template.jsonc | 将区域开关/选项改为可参数化的通用模板占位符,支持按数据生成不同区域节点。 |
| tools/pipeline-generate/SellProduct/task-config.json | 更新生成配置(新增 task: true,调整生成行为配置项)。 |
| tools/pipeline-generate/SellProduct/data.mjs | 增加按区域聚合的售卖点选项映射,并调整导出以配合模板生成。 |
| assets/tasks/SellProduct.json | 同步更新生成产物(由新模板/数据生成),包含注释移除与部分数组内容去重。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
通过使用共享数据层和更新后的模板,在 maa-pipeline 生成器中生成 SellProduct 任务。
新功能:
增强改进:
Original summary in English
Summary by Sourcery
Generate SellProduct tasks via the maa-pipeline generator using a shared data layer and updated templates.
New Features:
Enhancements: