Conversation
Contributor
There was a problem hiding this comment.
Hey - 我已经review了你的改动,看起来非常不错!
帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈改进 review 质量。
Original comment in English
Hey - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
There was a problem hiding this comment.
Pull request overview
该 PR 旨在修复 Issue #1747 中“武陵地图万能跳转到天井院等锚点失效(地图拖动到底部卡住)”的问题,通过将武陵相关锚点定位从旧的模板匹配+滑动方案重构为 MapTrackerBigMapPick 的大地图坐标拾取方案,以提升稳定性并减少对滑动锚点的依赖。
Changes:
- 将武陵(景玉谷/武陵城)部分“找锚点并进入大世界”的流程改为
custom_action: MapTrackerBigMapPick(SceneTeleportWuling + Interface 入口改线)。 - 调整地图传送相关节点的 freeze wait 逻辑(移除部分
post_wait_freezes,在关键点击前增加/缩短pre_wait_freezes)。 - 清理/替换旧的模板识别锚点节点(大量
__ScenePrivateMapUnknownEnterWorld...Try1/2/3 节点被移除)。
Reviewed changes
Copilot reviewed 5 out of 35 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| assets/resource/pipeline/SceneManager/SceneValleyIV.json | 移除一个点击后的 post_wait_freezes,与本次“减少 freeze wait 依赖”的方向一致。 |
| assets/resource/pipeline/SceneManager/SceneTeleportWuling.json | 将武陵锚点定位大幅改为 MapTrackerBigMapPick 坐标拾取,替代旧 TemplateMatch 多 Try 节点。 |
| assets/resource/pipeline/SceneManager/SceneMap.json | 调整传送候选/确认前后的 pre_wait_freezes/post_wait_freezes,降低卡顿/误判风险。 |
| assets/resource/pipeline/SceneManager/SceneDijiang.json | 移除一个点击后的 post_wait_freezes。 |
| assets/resource/pipeline/Interface/SceneWuling.json | Interface 入口改为通过 __ScenePrivateMapMapTrackerBigMapPickAnchor 触发 pick 流程(但目前存在分支未正确改线的问题)。 |
Comments suppressed due to low confidence (3)
assets/resource/pipeline/Interface/SceneWuling.json:66
SceneEnterWorldWulingJingyuValley3里 anchor 已改为__ScenePrivateMapMapTrackerBigMapPickAnchor,但next仍调用__ScenePrivateMapWulingJingyuValleyEnterWorldAnchor(滑动锚点方案)。这会导致 MapTracker 的 pick 节点不会被执行,且滑动锚点/UnknownTry* 也未在此场景设置,实际跳转大概率失败。建议将next改为__ScenePrivateMapWulingJingyuValleyEnterWorldAnchorWithPick(或恢复并补全滑动锚点相关 anchor 配置)。
assets/resource/pipeline/Interface/SceneWuling.json:251SceneEnterWorldWulingWulingCity6的 anchor 已切换为__ScenePrivateMapMapTrackerBigMapPickAnchor,但next仍指向__ScenePrivateMapWulingWulingCityEnterWorldAnchor(依赖滑动锚点)。当前场景未再提供 SwipeToStep*/UnknownTry* 的 anchor,且 pick anchor 在该分支不会被消费,可能导致进入大世界失败。建议这里也改为调用__ScenePrivateMapWulingWulingCityEnterWorldAnchorWithPick(或恢复滑动锚点配置)。
assets/resource/pipeline/Interface/SceneWuling.json:263SceneEnterWorldWulingWulingCity7同样已改用__ScenePrivateMapMapTrackerBigMapPickAnchor,但next仍调用旧的__ScenePrivateMapWulingWulingCityEnterWorldAnchor。这会使 MapTracker 的 pick 节点不会被执行,且缺少滑动锚点配置时容易直接失败。建议将next改为__ScenePrivateMapWulingWulingCityEnterWorldAnchorWithPick(或补回 SwipeToStep*/UnknownTry* anchor)。
Comment on lines
58
to
62
| "pre_delay": 0, | ||
| "anchor": { | ||
| "__ScenePrivateMapSwipeToStep0Anchor": "__ScenePrivateMapSwipeToStep0", | ||
| "__ScenePrivateMapSwipeToStep1Anchor": "__ScenePrivateMapSwipeToStep1TopRight", | ||
| "__ScenePrivateMapSwipeToStepFinishAnchor": "__ScenePrivateMapSwipeToStepFinishBottomRight", | ||
| "__ScenePrivateMapUnknownEnterWorldAnchorTry1": "__ScenePrivateMapUnknownEnterWorldWulingJingyuValley3Try1", | ||
| "__ScenePrivateMapUnknownEnterWorldAnchorTry2": "__ScenePrivateMapUnknownEnterWorldWulingJingyuValley3Try2", | ||
| "__ScenePrivateMapUnknownEnterWorldAnchorTry3": "__ScenePrivateMapUnknownEnterWorldWulingJingyuValley3Try3" | ||
| "__ScenePrivateMapMapTrackerBigMapPickAnchor": "__ScenePrivateMapWulingJingyuValleyEnterWorldWulingJingyuValley3Try0" | ||
| }, | ||
| "post_delay": 0, |
There was a problem hiding this comment.
SceneEnterWorldWulingJingyuValley3 的 anchor 对象只有一个字段,但末尾多了一个逗号(...Try0",),这在非 JSONC/不允许 trailing comma 的解析器下会直接导致文件解析失败。建议移除该 trailing comma,保持与同文件其它 anchor 写法一致。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #1747
Summary by Sourcery
改进内容:
SceneWuling和相关的SceneManagerJSON 中保持一致。Original summary in English
Summary by Sourcery
Enhancements: