Merged
Conversation
Contributor
There was a problem hiding this comment.
嗨——我已经审查了你的修改,整体看起来非常棒!
帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈来改进后续的审查。
Original comment in English
Hey - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
There was a problem hiding this comment.
Pull request overview
该 PR 针对 Issue #1764「售卖产品 点击+号位置错误导致只能进行单次交易」进行修复:通过调整进度条右侧点击节点的匹配排序与点击偏移,使点击位置更稳定准确,并补充对应的回归测试用例覆盖 Win32/ADB。
Changes:
- 在 SellProduct 的核心流水线中为
SellProductClickBarRight增加模板匹配结果按分数排序(order_by: Score),并调整点击偏移target_offset。 - 移除 ADB 专用的
SellProductClickBarRight偏移覆盖,使其复用主资源流水线的修正参数。 - 新增
SellProductClickBarRight的测试用例文件,覆盖多个据点场景并分别校验 Win32/ADB 点击命中框。
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/SellProduct/test_sell_core.json | 新增售卖核心流程回归测试,用命中框验证 SellProductClickBarRight 的点击位置(Win32/ADB) |
| assets/resource/pipeline/SellProduct/SellCore.json | 为 SellProductClickBarRight 增加 order_by: Score 并调整 target_offset,提升点击稳定性与准确性 |
| assets/resource_adb/pipeline/SellProduct/SellCore.json | 删除 ADB 对 SellProductClickBarRight 的偏移覆盖,统一使用主流水线的修复参数 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed #1764
Summary by Sourcery
修复 SellProduct 流水线以确保重复交易能正常运行,并为修正后的行为增加测试覆盖。
Bug Fixes:
SellCore流水线中点击处理不正确的问题,该问题曾导致用户只能完成一次交易。Tests:
SellCore流水线添加测试夹具(test fixture),以覆盖修正后的多次交易行为。Original summary in English
Summary by Sourcery
Fix the SellProduct pipeline so repeated trades work correctly and add coverage for the corrected behavior.
Bug Fixes:
Tests: