Conversation
Closed
Closed
Closed
Closed
This was
linked to
issues
Mar 30, 2026
Closed
Closed
Closed
Contributor
There was a problem hiding this comment.
Hey - 我给出了一些整体性的反馈:
- 新增的
Priority2OCR_CanNotAfford和Priority3OCR_CanNotAfford键与普通 OCR 条目使用了相同的expected值;建议将其重构为一个辅助函数或共享常量,以避免重复并让配置映射更易于维护。
给 AI Agent 的提示
Please address the comments from this code review:
## Overall Comments
- The new `Priority2OCR_CanNotAfford` and `Priority3OCR_CanNotAfford` keys duplicate the same `expected` value as the normal OCR entries; consider refactoring this into a helper or shared constant to avoid repetition and keep the configuration map more maintainable.帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈改进后续评审。
Original comment in English
Hey - I've left some high level feedback:
- The new
Priority2OCR_CanNotAffordandPriority3OCR_CanNotAffordkeys duplicate the sameexpectedvalue as the normal OCR entries; consider refactoring this into a helper or shared constant to avoid repetition and keep the configuration map more maintainable.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `Priority2OCR_CanNotAfford` and `Priority3OCR_CanNotAfford` keys duplicate the same `expected` value as the normal OCR entries; consider refactoring this into a helper or shared constant to avoid repetition and keep the configuration map more maintainable.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
There was a problem hiding this comment.
Pull request overview
该 PR 旨在修复帝江线基建奖励流程与信用点商店(CreditShopping)相关的识别/购买逻辑问题,并同步更新界面选项文案与后端解析覆盖参数,以提升自动化流程的稳定性与可配置性。
Changes:
- 调整 DijiangRewards 任务中的线索库存阈值识别规则,并清理部分培养舱种子检查的覆盖配置。
- 重构 CreditShopping 的优先级购买节点命名与执行顺序,补齐“买不起”场景下 Priority2/3 的识别与折扣匹配链路。
- 为 CreditShopping 新增/更新多语言选项描述,并在 go-service 中扩展 pipeline override 覆盖到新增的 *_CanNotAfford OCR 节点。
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| assets/tasks/DijiangRewards.json | 更新线索库存计数 expected 正则;移除一段培养舱种子非空检查的 pipeline_override。 |
| assets/tasks/CreditShopping.json | Priority1 选项增加 description;将开关覆盖节点从 BuyFirst 重命名为 BuyPriority1;更新折扣识别覆盖并补齐 Priority2/3 “买不起”分支覆盖。 |
| assets/resource/pipeline/SceneManager/SceneDijiang.json | 在进入总控中枢入口动作前增加 pre_wait_freezes 等待静止。 |
| assets/resource/pipeline/DijiangRewards/GrowthChamber.json | 调整“再次种植”按钮 OCR 的 ROI 区域。 |
| assets/resource/pipeline/CreditShopping/Shopping.json | 将主购买节点改为 CreditShoppingBuyPriority1;调整 next 顺序(ReserveCredit 前置到 Priority2/3 之前);新增 AutoGetCreditsBuyPriority2/3 识别组合。 |
| assets/resource/pipeline/CreditShopping/Item.json | 新增 Priority2/3 的 *_CanNotAfford OCR 与对应折扣匹配节点。 |
| assets/locales/interface/zh_tw.json | 更新 CreditShopping Priority 文案,并新增 description 文案键。 |
| assets/locales/interface/zh_cn.json | 更新 CreditShopping Priority 文案,并新增 description 文案键。 |
| assets/locales/interface/ko_kr.json | 更新 CreditShopping Priority 文案,并新增 description 文案键。 |
| assets/locales/interface/ja_jp.json | 更新 CreditShopping Priority 文案,并新增 description 文案键。 |
| assets/locales/interface/en_us.json | 更新 CreditShopping Priority 文案,并新增 description 文案键。 |
| agent/go-service/creditshopping/creditshopping.go | pipeline override 覆盖范围扩展到 Priority2/3 的 *_CanNotAfford OCR 节点。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
修复积分商店解析和地脊奖励配置相关问题。
Bug 修复:
增强改进:
Original summary in English
Summary by Sourcery
Fix credit shop parsing and Dijiang reward configuration issues.
Bug Fixes:
Enhancements:
Original summary in English
Summary by Sourcery
修复积分商店解析和地脊奖励配置相关问题。
Bug 修复:
增强改进:
Original summary in English
Summary by Sourcery
Fix credit shop parsing and Dijiang reward configuration issues.
Bug Fixes:
Enhancements: