Merged
Conversation
…handling in AfterBattleTierGate action
Contributor
There was a problem hiding this comment.
嗨,我已经审查了你的修改,看起来非常不错!
帮助我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈改进后续的评审。
Original comment in English
Hey - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
There was a problem hiding this comment.
Pull request overview
该 PR 围绕 Issue #1721,对“基质筛选”任务的“跳过缩略图标记”能力做了拆分:将“跳过锁定/废弃”从一个总开关细化为两个独立开关,并在 Go 侧与 pipeline 侧同时打通对应参数与识别节点,以便用户分别控制“已锁定”“已废弃”的跳过策略。
Changes:
- 将任务选项从
SkipLockedRow拆分为SkipThumbLock/SkipThumbDiscard,并更新各语言 UI 文案。 - Pipeline 新增单模板识别节点
EssenceThumbLock/EssenceThumbDiscard,Go 侧按开关组合选择调用(两者都开则复用EssenceThumbMarked)。 - Go 侧 attach/options 解析新增两个字段,并保留对旧字段
skip_locked_row的兼容映射。
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| assets/tasks/EssenceFilter.json | 任务选项列表改为两个独立跳过开关,并通过 pipeline_override 写入新 attach 字段 |
| assets/resource/pipeline/EssenceFilter/LockDiscard.json | 新增两个单模板缩略图标记识别节点,供 Go 侧按需调用 |
| assets/resource/pipeline/AutoEssence/EssenceFilterAfterBattle.json | after-battle 默认 attach 字段同步为新 skip_thumb_* 字段 |
| assets/locales/interface/zh_tw.json | UI 文案改为两个开关对应的 label/description |
| assets/locales/interface/zh_cn.json | UI 文案改为两个开关对应的 label/description,并调整部分 focus 文案措辞 |
| assets/locales/interface/ko_kr.json | UI 文案改为两个开关对应的 label/description |
| assets/locales/interface/ja_jp.json | UI 文案改为两个开关对应的 label/description |
| assets/locales/interface/en_us.json | UI 文案改为两个开关对应的 label/description |
| agent/go-service/essencefilter/types.go | Options 结构体新增 SkipThumbLock/SkipThumbDiscard 字段 |
| agent/go-service/essencefilter/options_resolve.go | 默认值与 patch 应用逻辑更新,并兼容旧 skip_locked_row 入参 |
| agent/go-service/essencefilter/actions.go | RowCollect 中按开关组合调用不同识别节点,支持单独跳过锁定/废弃 |
| agent/go-service/essencefilter/README.md | 更新数据流说明,补充新字段与旧字段兼容说明 |
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1721
Summary by Sourcery
在精华过滤行收集管道中支持分别跳过已锁定缩略图和已丢弃缩略图,同时保持对传统选项的向后兼容性。
新功能:
增强:
skip-locked-row选项时,将其映射到新的缩略图跳过选项上来保持向后兼容性。文档:
Original summary in English
Summary by Sourcery
Support separate skipping of locked and discarded thumbnails in the essence filter row collection pipeline while maintaining backward compatibility with the legacy option.
New Features:
Enhancements:
Documentation:
新功能:
skip_thumb_lock和skip_thumb_discard选项,用于在本质过滤过程中控制对已锁定和已丢弃缩略图的跳过行为。增强:
skip_locked_row视为兼容别名。Original summary in English
Summary by Sourcery
在精华过滤行收集管道中支持分别跳过已锁定缩略图和已丢弃缩略图,同时保持对传统选项的向后兼容性。
新功能:
增强:
skip-locked-row选项时,将其映射到新的缩略图跳过选项上来保持向后兼容性。文档:
Original summary in English
Summary by Sourcery
Support separate skipping of locked and discarded thumbnails in the essence filter row collection pipeline while maintaining backward compatibility with the legacy option.
New Features:
Enhancements:
Documentation: