Merged
Conversation
Closed
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - 我在这里给出了一些整体反馈：
- 新的缺失物料（missing-material）处理逻辑分别单独加入了标准和 ADB GrowthChamber 的 pipeline/template 中；可以考虑抽取出共享结构，或者使用公共 include，这样更容易保持这些配置的一致性。
- 在更新后的 DijiangRewards 任务配置里，可以评估一下是否能把缺失物料流程建模为一个可复用的子任务或共享的状态转换块，而不是在多个位置重复类似的状态/转换定义。
给 AI Agent 的提示
请根据这次代码审查中的评论进行修改：
## 总体评论
- 新的缺失物料（missing-material）处理逻辑分别单独加入了标准和 ADB GrowthChamber 的 pipeline/template 中；可以考虑抽取出共享结构，或者使用公共 include，这样更容易保持这些配置的一致性。
- 在更新后的 DijiangRewards 任务配置里，可以评估一下是否能把缺失物料流程建模为一个可复用的子任务或共享的状态转换块，而不是在多个位置重复类似的状态/转换定义。帮我变得更有用！请在每条评论上点 👍 或 👎，我会根据你的反馈来改进后续的评审。
Original comment in English
Hey - I've left some high level feedback:
- The new missing-material handling appears to be added separately to both the standard and ADB GrowthChamber pipelines/templates; consider extracting the shared structure or using a common include so these configurations stay in sync more easily.
- In the updated DijiangRewards task configuration, review whether the missing-material flow can be modeled as a reusable sub-task or shared transition block rather than duplicating similar state/transition definitions in multiple places.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new missing-material handling appears to be added separately to both the standard and ADB GrowthChamber pipelines/templates; consider extracting the shared structure or using a common include so these configurations stay in sync more easily.
- In the updated DijiangRewards task configuration, review whether the missing-material flow can be modeled as a reusable sub-task or shared transition block rather than duplicating similar state/transition definitions in multiple places.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
There was a problem hiding this comment.
Pull request overview
本 PR 更新了 DijiangRewards 培养舱（GrowthChamber）相关的任务配置与流水线节点，旨在更好地处理“缺少原料”等异常分支，并补齐用于判断目标可用性的状态模板。
Changes:
- 将任务侧的目标数量检查从
GrowthChamberCheckTargetEmpty迁移/细化为GrowthChamberCheckSeedNotEmpty等新状态名，并在部分场景引入GrowthChamberCheckTargetNotEmpty - 扩展状态模板（含 ADB 变体），新增“基核数量/本体数量非 0”的识别定义，并提供
TargetNotEmpty聚合判断 - 在培养舱流水线中新增“列表到底”识别节点（含 ADB ROI），并调整部分分支返回路径以配合异常处理
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| assets/tasks/DijiangRewards.json | 更新任务选项/物品的 pipeline_override 状态名，并新增 GrowthChamberCheckTargetNotEmpty override |
| assets/resource/pipeline/DijiangRewards/Template/Status.json | 新增 SeedNotEmpty / PlantNotEmpty / TargetNotEmpty 状态模板与识别逻辑 |
| assets/resource/pipeline/DijiangRewards/GrowthChamber.json | 流水线新增“滑动到底”相关节点，并调整部分分支 next 路径 |
| assets/resource_adb/pipeline/DijiangRewards/Template/Status.json | 为 ADB 变体补充新状态的 ROI offset |
| assets/resource_adb/pipeline/DijiangRewards/GrowthChamber.json | 为 ADB 变体补充 GrowthChamberScrollEnd ROI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
在 DijiangRewards GrowthChamber 流水线中处理缺失物料（missing-material）场景，并将新的状态向相关配置中传播。
新功能：
增强改进：
Original summary in English
Summary by Sourcery
Handle missing-material scenarios in the DijiangRewards GrowthChamber pipeline and propagate the new state through related configuration.
New Features:
Enhancements:
新功能：
增强改进：
Original summary in English
Summary by Sourcery
在 DijiangRewards GrowthChamber 流水线中处理缺失物料（missing-material）场景，并将新的状态向相关配置中传播。
新功能：
增强改进：
Original summary in English
Summary by Sourcery
Handle missing-material scenarios in the DijiangRewards GrowthChamber pipeline and propagate the new state through related configuration.
New Features:
Enhancements: