Merged
Conversation
Closed
Contributor
There was a problem hiding this comment.
嗨,我已经审查了你的改动,一切看起来都很棒!
帮我变得更有用!请对每条评论点选 👍 或 👎,我会根据你的反馈改进之后的评审。
Original comment in English
Hey - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
There was a problem hiding this comment.
Pull request overview
该 PR 旨在修复“稳健刷新模式”下由于 pipeline/task 覆盖内容不完整导致识别被判定为直接命中(DirectHit)的问题,同时对 ExpressionRecognition 的评估日志输出做了小幅重构,便于统一维护。
Changes:
- 在
assets/tasks/CreditShopping.json中补全CreditShoppingPrudentRefresh的recognition覆盖:显式指定type: And、补全Custom(ExpressionRecognition)定义,并设置合适的box_index。 - 在
assets/resource/pipeline/CreditShopping/Shopping.json中将稳健刷新相关的自定义识别切换为ExpressionRecognition(与表达式配置一致)。 - 在
agent/go-service/expressionrecognition/recognition.go中将表达式评估结果的日志构建提取到独立辅助函数logEvaluationResult。
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| assets/tasks/CreditShopping.json | 补全稳健刷新阈值的 pipeline_override 识别配置,避免覆盖不全导致 DirectHit,并补充 box_index。 |
| assets/resource/pipeline/CreditShopping/Shopping.json | 将稳健刷新判断用的 custom_recognition 调整为 ExpressionRecognition,以正确评估表达式条件。 |
| agent/go-service/expressionrecognition/recognition.go | 抽取表达式评估日志到 helper,降低 Run 函数内的日志样板代码。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
增强功能:
Original summary in English
Summary by Sourcery
Enhancements:
Original summary in English
Summary by Sourcery
增强功能:
Original summary in English
Summary by Sourcery
Enhancements: