Conversation
There was a problem hiding this comment.
嗨——我已经审查了你的更改,看起来非常不错!
帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈改进今后的审查。
Original comment in English
Hey - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull request overview
本 PR 旨在更新 go-service 的“分辨率/纵横比不匹配”提示文案,使其对用户的操作指引更具体(不同语言的本地化文案同步更新)。
Changes:
- 更新
tasker.aspect_ratio_warning.desc在多语言(zh_cn/zh_tw/en_us/ja_jp/ko_kr)中的提示文案 - 将原先“仅支持 16:9”的描述扩展为“全屏/窗口模式下如何处理”的指引
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| assets/locales/go-service/zh_cn.json | 更新纵横比警告描述文案(简中) |
| assets/locales/go-service/zh_tw.json | 更新纵横比警告描述文案(繁中) |
| assets/locales/go-service/en_us.json | Update aspect-ratio warning description (EN) |
| assets/locales/go-service/ja_jp.json | Update aspect-ratio warning description (JP) |
| assets/locales/go-service/ko_kr.json | Update aspect-ratio warning description (KR) |
| "tasker.aspect_ratio_warning.title": "🚨 警告:分辨率比例不匹配!🚨", | ||
| "tasker.aspect_ratio_warning.stopped": "🚫 任务已强制停止", | ||
| "tasker.aspect_ratio_warning.desc": "💡 MaaEnd 目前 <span style=\"text-decoration: underline; font-size: 1.1em;\">仅支持 16:9</span> 比例。", | ||
| "tasker.aspect_ratio_warning.desc": "💡 全屏模式仅支持 16:9 显示器;窗口化模式下可将分辨率手动设为 16:9。", |
There was a problem hiding this comment.
这里的提示把问题归因为“全屏模式仅支持 16:9 显示器/ディスプレイ/모니터”,但实际触发条件是 controller.GetResolution() 返回的分辨率纵横比不为 16:9(与是否全屏无直接判断)。建议文案改为围绕“当前仅支持 16:9 分辨率/纵横比”,并把“若全屏下难以调整到 16:9,可改用窗口模式手动设为 16:9”作为建议,以避免误导。
| "tasker.aspect_ratio_warning.desc": "💡 全屏模式仅支持 16:9 显示器;窗口化模式下可将分辨率手动设为 16:9。", | |
| "tasker.aspect_ratio_warning.desc": "💡 当前任务仅支持 16:9 分辨率(纵横比)。若在全屏模式下难以将分辨率调整为 16:9,可切换到窗口模式并手动将分辨率设为 16:9。", |
| "tasker.aspect_ratio_warning.title": "🚨 警告:解析度比例不相符!🚨", | ||
| "tasker.aspect_ratio_warning.stopped": "🚫 任務已強制停止", | ||
| "tasker.aspect_ratio_warning.desc": "💡 MaaEnd 目前 <span style=\"text-decoration: underline; font-size: 1.1em;\">僅支援 16:9</span> 比例。", | ||
| "tasker.aspect_ratio_warning.desc": "💡 全螢幕模式僅支援 16:9 顯示器;視窗化模式下可將解析度手動設為 16:9。", |
There was a problem hiding this comment.
该文案使用“全螢幕模式僅支援 16:9 顯示器”的表述,但实际检查的是当前分辨率的纵横比是否为 16:9,并不会判断全螢幕/視窗模式。建议改成“目前僅支援 16:9 分辨率/比例”,并补充“若全螢幕分辨率无法调整,可改用視窗化手动设为 16:9”的建议,避免将问题错误归因到显示器。
| "tasker.aspect_ratio_warning.desc": "💡 全螢幕模式僅支援 16:9 顯示器;視窗化模式下可將解析度手動設為 16:9。", | |
| "tasker.aspect_ratio_warning.desc": "💡 目前僅支援 16:9 解析度/比例。若全螢幕解析度無法調整,可改用視窗化手動設為 16:9。", |
| "tasker.aspect_ratio_warning.title": "🚨 Warning: Aspect ratio mismatch! 🚨", | ||
| "tasker.aspect_ratio_warning.stopped": "🚫 Task has been force-stopped", | ||
| "tasker.aspect_ratio_warning.desc": "💡 MaaEnd currently supports <span style=\"text-decoration: underline; font-size: 1.1em;\">16:9 only</span>.", | ||
| "tasker.aspect_ratio_warning.desc": "💡 Fullscreen mode only supports 16:9 displays; in windowed mode, you can manually set the resolution to 16:9.", |
There was a problem hiding this comment.
This message states “Fullscreen mode only supports 16:9 displays”, but the actual trigger is the current resolution aspect ratio not being ~16:9 (see aspect ratio checker using controller.GetResolution), without detecting fullscreen/windowed mode. Suggest rewording to focus on “only 16:9 resolution/aspect ratio is supported” and present windowed-mode 16:9 as a workaround if fullscreen resolution can’t be adjusted, to avoid misleading users.
| "tasker.aspect_ratio_warning.desc": "💡 Fullscreen mode only supports 16:9 displays; in windowed mode, you can manually set the resolution to 16:9.", | |
| "tasker.aspect_ratio_warning.desc": "💡 Only 16:9 resolutions are currently supported. If you can't set a 16:9 resolution in fullscreen, switch to windowed mode and use a 16:9 resolution (e.g. 1920×1080).", |
| "tasker.aspect_ratio_warning.title": "🚨 警告:解像度のアスペクト比が一致しません!🚨", | ||
| "tasker.aspect_ratio_warning.stopped": "🚫 タスクを強制停止しました", | ||
| "tasker.aspect_ratio_warning.desc": "💡 MaaEnd は現時点で <span style=\"text-decoration: underline; font-size: 1.1em;\">16:9 のみ</span> をサポートしています。", | ||
| "tasker.aspect_ratio_warning.desc": "💡 フルスクリーンは 16:9 のディスプレイのみ対応。ウィンドウ表示では手動で解像度を 16:9 に設定できます。", |
There was a problem hiding this comment.
文案里提到「フルスクリーンは 16:9 のディスプレイのみ対応」ですが、実際の判定は GetResolution() で取得した解像度のアスペクト比が 16:9 かどうかで、フルスクリーン/ウィンドウの判定はしていません。誤解を避けるため、「現在は 16:9 の解像度(アスペクト比)のみ対応」+「フルスクリーンで調整できない場合はウィンドウ表示で 16:9 に設定」を推奨、のように表現を寄せるのが安全です。
| "tasker.aspect_ratio_warning.desc": "💡 フルスクリーンは 16:9 のディスプレイのみ対応。ウィンドウ表示では手動で解像度を 16:9 に設定できます。", | |
| "tasker.aspect_ratio_warning.desc": "💡 現在は 16:9 の解像度(アスペクト比)のみ対応しています。フルスクリーンで調整できない場合は、ウィンドウ表示で解像度を 16:9 に設定してください。", |
| "tasker.aspect_ratio_warning.title": "🚨 경고: 해상도 비율이 맞지 않습니다! 🚨", | ||
| "tasker.aspect_ratio_warning.stopped": "🚫 작업이 강제로 중지되었습니다", | ||
| "tasker.aspect_ratio_warning.desc": "💡 MaaEnd는 현재 <span style=\"text-decoration: underline; font-size: 1.1em;\">16:9 비율만</span> 지원합니다.", | ||
| "tasker.aspect_ratio_warning.desc": "💡 전체 화면은 16:9 모니터만 지원합니다. 창 모드에서는 해상도를 수동으로 16:9로 설정할 수 있습니다.", |
There was a problem hiding this comment.
문구가 “전체 화면은 16:9 모니터만 지원”이라고 단정하지만, 실제로는 GetResolution()로 얻은 현재 해상도의 종횡비가 16:9인지 검사할 뿐 전체 화면/창 모드를 구분하지 않습니다. 오해를 줄이려면 “현재 16:9 해상도(종횡비)만 지원”으로 중심을 잡고, “전체 화면에서 16:9로 맞추기 어렵다면 창 모드에서 16:9로 수동 설정”을 우회 방법으로 안내하는 표현이 더 정확합니다.
| "tasker.aspect_ratio_warning.desc": "💡 전체 화면은 16:9 모니터만 지원합니다. 창 모드에서는 해상도를 수동으로 16:9로 설정할 수 있습니다.", | |
| "tasker.aspect_ratio_warning.desc": "💡 현재 16:9 해상도(종횡비)만 지원합니다. 전체 화면에서 16:9로 맞추기 어렵다면 창 모드에서 해상도를 16:9로 수동 설정해 주세요.", |
Summary by Sourcery
增强内容:
Original summary in English
Summary by Sourcery
Enhancements: