Merged
Conversation
Contributor
There was a problem hiding this comment.
嗨,我已经审阅了你的修改,看起来很棒!
帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈改进后续的评审。
Original comment in English
Hey - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
dongwlin
approved these changes
Mar 25, 2026
|
|
||
| - 上下文(组件名、步骤、场景)用链式字段,禁止拼进 `Msg`。 | ||
| - 错误、参数、识别结果一律用链式字段(`.Err(err)`、`.Int("x", x)`)。 | ||
|
|
Contributor
There was a problem hiding this comment.
日志里再加一条统一用英文吧,我今天看好像有个模块的作者喜欢一会中文日志,一会英文日志的
Contributor
Author
There was a problem hiding this comment.
倒是无所谓,反正都是开发者自己看,自己能看懂就行了
Contributor
There was a problem hiding this comment.
Pull request overview
本 PR 旨在把 MaaEnd 的 Go(go-service)与 Pipeline JSON 编写规范整理为独立的 “skill” 文档,便于后续 AI/协作者统一遵循同一份指南。
Changes:
- 新增
.claude/skills/go-service-guide:沉淀 go-service 的结构/注册/日志/注释等规范与模板 - 新增
.claude/skills/pipeline-guide:提供 Pipeline 编写指南与字段速查表 - 精简 go-service 路径专属指令文件为对 skill 文档的引用,并调整
.gitignore中与.claude相关规则
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| .gitignore | 移除对 .claude/ 的忽略规则 |
| .github/instructions/go-service.instructions.md | go-service 路径指令改为引用 go-service skill 文档 |
| .claude/skills/pipeline-guide/field-reference.md | 新增 Pipeline 字段速查表 |
| .claude/skills/pipeline-guide/SKILL.md | 新增 Pipeline 编写规范与模式说明 |
| .claude/skills/go-service-guide/SKILL.md | 新增 go-service 编写规范与模板 |
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
看看,主要是 go 的,每次 cursor 写出来的都不符合 Copilot 的规范,干脆单独整理一份
Summary by Sourcery
为 MaaEnd pipeline JSON 编写和 go-service Go 代码规范新增专用的 Claude 技能,并更新现有的 Go 服务说明,指向新的共享指南。
增强:
文档:
Original summary in English
Summary by Sourcery
Add dedicated Claude skills for MaaEnd pipeline JSON authoring and go-service Go code conventions, and update existing Go service instructions to point to the new shared guide.
Enhancements:
Documentation: