Merged
Conversation
Contributor
There was a problem hiding this comment.
Hey - 我在这里给出了一些整体性的反馈:
- 对于“刷新次数耗尽时自动购买”的新逻辑,建议在 pipeline 中增加一个清晰的配置/开关,这样可以在不改动代码的情况下切换或调整行为,尤其可以避免在某些市场给用户带来意外的体验。
- 请再次确认与自动购买相关的新/修改的本地化 key 在所有语言文件中保持一致(key 相同、没有遗留或重复的 key),以避免运行时意外回退到默认文案。
- 在
CreditShopping/Shopping.json的 pipeline 中,请确保在自动购买失败时(例如余额不足或网络错误)有一条明确的回退路径,这样在刷新尝试次数耗尽后,用户不会处于无法继续使用的状态。
AI 代理的提示词
Please address the comments from this code review:
## Overall Comments
- 对于“刷新次数耗尽时自动购买”的新逻辑,建议在 pipeline 中增加一个清晰的配置/开关,这样可以在不改动代码的情况下切换或调整行为,尤其可以避免在某些市场给用户带来意外的体验。
- 请再次确认与自动购买相关的新/修改的本地化 key 在所有语言文件中保持一致(key 相同、没有遗留或重复的 key),以避免运行时意外回退到默认文案。
- 在 `CreditShopping/Shopping.json` 的 pipeline 中,请确保在自动购买失败时(例如余额不足或网络错误)有一条明确的回退路径,这样在刷新尝试次数耗尽后,用户不会处于无法继续使用的状态。帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈改进后续评审。
Original comment in English
Hey - I've left some high level feedback:
- For the new auto-purchase on refresh exhaustion, consider adding a clear configuration/flag in the pipeline so the behavior can be toggled or adjusted without further code changes, especially to avoid surprising users in certain markets.
- Please double-check that the new/changed localization keys for auto-purchase are consistent across all locale files (same keys, no dangling or duplicated keys), so the runtime doesn’t fall back unexpectedly to default strings.
- In the
CreditShopping/Shopping.jsonpipeline, ensure there is an explicit fallback path when auto-purchase fails (e.g., insufficient balance or network error) so the user isn’t left in an unusable state after refresh attempts are exhausted.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- For the new auto-purchase on refresh exhaustion, consider adding a clear configuration/flag in the pipeline so the behavior can be toggled or adjusted without further code changes, especially to avoid surprising users in certain markets.
- Please double-check that the new/changed localization keys for auto-purchase are consistent across all locale files (same keys, no dangling or duplicated keys), so the runtime doesn’t fall back unexpectedly to default strings.
- In the `CreditShopping/Shopping.json` pipeline, ensure there is an explicit fallback path when auto-purchase fails (e.g., insufficient balance or network error) so the user isn’t left in an unusable state after refresh attempts are exhausted.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
There was a problem hiding this comment.
Pull request overview
本 PR 在信用点购物(CreditShopping)流程中补充“刷新次数耗尽后自动购买”的分支,并同步更新多语言界面文案,以适配新的行为与提示。
Changes:
- 在 CreditShopping 扫描/ADB 特殊流程的 next 列表中插入“刷新次数耗尽时直接购买”的节点。
- 新增 CreditShoppingRefreshCountReached 节点:检测“今日刷新次数已用尽”提示后,直接点击可购买物品进入购买流程。
- 更新 zh_cn/zh_tw/en_us/ja_jp/ko_kr 的提示文案与选项说明,描述刷新次数耗尽时的处理。
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| assets/resource/pipeline/CreditShopping/Shopping.json | 增加刷新次数耗尽检测节点,并调整扫描流程的 next 顺序以触发自动购买 |
| assets/locales/interface/zh_cn.json | 新增对应 task 文案并更新选项说明(简体中文) |
| assets/locales/interface/zh_tw.json | 新增对应 task 文案并更新选项说明(繁体中文) |
| assets/locales/interface/en_us.json | 新增对应 task 文案并更新选项说明(英文) |
| assets/locales/interface/ja_jp.json | 新增对应 task 文案并更新选项说明(日文) |
| assets/locales/interface/ko_kr.json | 新增对应 task 文案并更新选项说明(韩文) |
Contributor
There was a problem hiding this comment.
Hey - 我给出了几条高层面的反馈:
- 在为新的自动购买行为更新 CreditShopping 流水线(pipeline)的 JSON 时,确保所有新增或重命名的状态/事件在所有相关的流水线文件(BuyItem、BuyItemFocus、ClaimCredit、GoToShop、Shopping)中都被一致地引用,避免出现孤立或失效的状态转换。
- 删除
assets/resource_adb/pipeline/CreditShopping/GoToShop.json看起来会改变 ADB 流程的行为;请核实之前引用该路径的任何工具或构建脚本,现在是否已经改为使用主路径assets/resource/pipeline/.../GoToShop.json,或者已经被显式更新,以避免在运行时查找已删除的文件。
面向 AI 代理的提示
Please address the comments from this code review:
## Overall Comments
- When updating the CreditShopping pipeline JSONs for the new auto-purchase behavior, ensure that any new or renamed states/events are consistently referenced across all related pipeline files (BuyItem, BuyItemFocus, ClaimCredit, GoToShop, Shopping) to avoid orphaned or dead transitions.
- The removal of `assets/resource_adb/pipeline/CreditShopping/GoToShop.json` looks like a behavior change for ADB flows; verify that any tooling or build scripts that previously referenced this path now either use the main `assets/resource/pipeline/.../GoToShop.json` or are explicitly updated to avoid runtime lookups of the deleted file.帮我变得更有用!请在每条评论上点击 👍 或 👎,我会根据你的反馈改进后续评审。
Original comment in English
Hey - I've left some high level feedback:
- When updating the CreditShopping pipeline JSONs for the new auto-purchase behavior, ensure that any new or renamed states/events are consistently referenced across all related pipeline files (BuyItem, BuyItemFocus, ClaimCredit, GoToShop, Shopping) to avoid orphaned or dead transitions.
- The removal of
assets/resource_adb/pipeline/CreditShopping/GoToShop.jsonlooks like a behavior change for ADB flows; verify that any tooling or build scripts that previously referenced this path now either use the mainassets/resource/pipeline/.../GoToShop.jsonor are explicitly updated to avoid runtime lookups of the deleted file.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- When updating the CreditShopping pipeline JSONs for the new auto-purchase behavior, ensure that any new or renamed states/events are consistently referenced across all related pipeline files (BuyItem, BuyItemFocus, ClaimCredit, GoToShop, Shopping) to avoid orphaned or dead transitions.
- The removal of `assets/resource_adb/pipeline/CreditShopping/GoToShop.json` looks like a behavior change for ADB flows; verify that any tooling or build scripts that previously referenced this path now either use the main `assets/resource/pipeline/.../GoToShop.json` or are explicitly updated to avoid runtime lookups of the deleted file.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
在刷新次数用尽时,添加自动购入点数的行为,并将其集成到点数购买流程和界面文案中。
新功能:
改进:
Original summary in English
Summary by Sourcery
Add automatic credit purchase behavior when refresh attempts are exhausted and integrate it into the credit shopping pipelines and UI copy.
New Features:
Enhancements:
新功能:
增强改进:
Original summary in English
Summary by Sourcery
在刷新次数用尽时,添加自动购入点数的行为,并将其集成到点数购买流程和界面文案中。
新功能:
改进:
Original summary in English
Summary by Sourcery
Add automatic credit purchase behavior when refresh attempts are exhausted and integrate it into the credit shopping pipelines and UI copy.
New Features:
Enhancements:
新功能:
增强:
Original summary in English
Summary by Sourcery
在刷新次数用尽时,添加自动购入点数的行为,并将其集成到点数购买流程和界面文案中。
新功能:
改进:
Original summary in English
Summary by Sourcery
Add automatic credit purchase behavior when refresh attempts are exhausted and integrate it into the credit shopping pipelines and UI copy.
New Features:
Enhancements:
新功能:
增强改进:
Original summary in English
Summary by Sourcery
在刷新次数用尽时,添加自动购入点数的行为,并将其集成到点数购买流程和界面文案中。
新功能:
改进:
Original summary in English
Summary by Sourcery
Add automatic credit purchase behavior when refresh attempts are exhausted and integrate it into the credit shopping pipelines and UI copy.
New Features:
Enhancements: