feat(AutoUseSpMedication): 支持仅使用即将过期的应急理智加强剂#1593
Merged
Conversation
Contributor
There was a problem hiding this comment.
你好——我给出了一些高层次的反馈:
- 建议在流水线/任务逻辑中进一步澄清并强制规范
UseRegularSpMedication和UseAllExpireSoonSpMedication之间的交互关系(例如:当二者都启用或都禁用时会发生什么),从而让行为是确定的、且易于理解。 - 对于
UseAllExpireSoonSpMedication的阈值(“剩余时间 < 3 天 / 变红”),请确保实现中使用与游戏内 UI 相同的边界条件和时间源,尤其要考虑恰好剩余 3 天、以及不同时区等边界情况。
面向 AI Agent 的提示
Please address the comments from this code review:
## Overall Comments
- Consider clarifying and enforcing the interaction between `UseRegularSpMedication` and `UseAllExpireSoonSpMedication` in the pipeline/task logic (e.g., what happens when both are enabled or both disabled) so the behavior is deterministic and easy to reason about.
- For the `UseAllExpireSoonSpMedication` threshold ("time limit < 3 days / turns red"), make sure the implementation uses the same boundary condition and time source as the in-game UI, especially for edge cases like exactly 3 days remaining or time zone differences.帮我变得更有用!请在每条评论上点击 👍 或 👎,我会根据你的反馈来改进后续的评审。
Original comment in English
Hey - I've left some high level feedback:
- Consider clarifying and enforcing the interaction between
UseRegularSpMedicationandUseAllExpireSoonSpMedicationin the pipeline/task logic (e.g., what happens when both are enabled or both disabled) so the behavior is deterministic and easy to reason about. - For the
UseAllExpireSoonSpMedicationthreshold ("time limit < 3 days / turns red"), make sure the implementation uses the same boundary condition and time source as the in-game UI, especially for edge cases like exactly 3 days remaining or time zone differences.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider clarifying and enforcing the interaction between `UseRegularSpMedication` and `UseAllExpireSoonSpMedication` in the pipeline/task logic (e.g., what happens when both are enabled or both disabled) so the behavior is deterministic and easy to reason about.
- For the `UseAllExpireSoonSpMedication` threshold ("time limit < 3 days / turns red"), make sure the implementation uses the same boundary condition and time source as the in-game UI, especially for edge cases like exactly 3 days remaining or time zone differences.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
zmdyy0318
approved these changes
Mar 25, 2026
CatGoldenglow
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
原有逻辑每次固定使用一颗应急理智加强剂,无法只使用过期药,
变更内容
新增两个独立开关:
UseRegularSpMedication(默认开启)
UseAllExpireSoonSpMedication(默认关闭)
Summary by Sourcery
为自动使用特殊理智药物新增可配置选项,包括仅消耗临期物品的支持。
新功能:
增强:
文档:
Original summary in English
Summary by Sourcery
Add configurable options to control automatic use of special sanity medication, including support for consuming only items that are close to expiry.
New Features:
Enhancements:
Documentation: