Conversation
The current DWI::Fixel_map<> class (to be deprecated in the future) contains at index 0 a fixel with an empty constructor. Any diagnosis information presented to the user should therefore be computed without consideration for this non-existing fixel.
MR::Axes::permutations_type: Fix is_identity()
fsl.check_first(): Handle run_first_all providing no HOLDID
Pipe image format: Revise error message
mrcalc: Docs: Combining mag&phase into complex data
mesh2voxel: Accept >3D image as template voxel grid
- unlock() must hold the mutex because it writes lockcentres[idx].second - ~SpatialLock() should also lock before clearing lockcentres to avoid a race if another thread is concurrently in try_lock()/unlock().
This class holds a reference and relies on its destructor to call `unlock`. The default copy/move will copy idx and the reference leading to double unlock() calls.
ParticlePool::size() was a const accessor that read pool.size() and avail.size() without taking the pool mutex. Other threads can call create()/destroy() which modify pool/avail under the mutex.
tck2connectome: Add default assignment mechanism to docs
Use an unsigned integer 3D texture for the ROI (GL_R8UI) to store a 0/1 mask without normalization. Previously, we were using an integer sampler with a GL_R8 texture leading to erraneous behaviour on MacOS. Any future code interacting with the ROI texture must avoid trying to enable filtering and use integer sampler to read from it.
Instead of using `glMultiDrawArrays`, which doesn't guarantee that draw calls will be executed in a batched fashion, we use `glDrawElements` with an index buffer. This fixes the performance issues seen on MacOS when visualising tractograms. See https://programming4.us/multimedia/8302.aspx
Qt5 links to both OpenGL and AGL for OpenGL apps, but AGL is no longer included in MacOS Tahoe/Xcode26 (https://bugreports.qt.io/browse/QTBUG-137687). This will cause our configure script to fail on latest macOS. This issue will not be addressed in future Qt5 versions (only in Qt6), but we can work around it by explicitly linking only to OpenGL.
tckglobal: Fix operation
Fixes for new GA releases workflow
We need to rebind the intended EBO for the current chunk of streamlines before drawing. Fixes streamline glitch when ODFs are loaded.
The latest version of Eigen (v5) requires C++17, while we only support C++11 on master.
Explicitly install eigen3 for macOS CI tests
Fix OpenGL state clobbering when rendering streamlines
Update copyright to 2026
Member
Author
|
Member
Author
|
|
Updates to both copyright years and fixed-tag documentation hyperlinks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge is necessary in order for CI tests of PRs targeting
devto pass, given that the copyright update pushed tomasterin #3252 needs to be ported todevalso.Duplicates fix in #3254.
masterthat are included here, and make sure that there are no fixes that have been discarded as part of the merge resolution process.