Fix Eigen 3.4.1 type mismatch in ColourMap clamping#3207
Merged
Conversation
Fix compilation error leading to Eigen::internal::traits<double> errors.
jdtournier
approved these changes
Oct 6, 2025
Member
jdtournier
left a comment
jdtournier
left a comment
There was a problem hiding this comment.
I think we've tended to use a lowercase f in other places with a float literal - not sure whether it's worth making it consistent before merging...? Suggested change looks fine otherwise.
Member
Author
|
I don't mind lowercase. I used uppercase because on |
Merged
Lestropie
added a commit
that referenced
this pull request
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix compilation error leading to
Eigen::internal::traits<double>errors.This is currently blocking PRs targeting
masterdue to CI build failures on macOS.