Skip to content

mrview: Bugfix in rendering of cubes in connectome tool#3204

Merged
Lestropie merged 2 commits intomasterfrom
mrview_cube_fix
Oct 9, 2025
Merged

mrview: Bugfix in rendering of cubes in connectome tool#3204
Lestropie merged 2 commits intomasterfrom
mrview_cube_fix

Conversation

@Lestropie
Copy link
Member

Problem introduced in 92eee2a as part of #283.

Have not yet tested for whether it has any effect, just spotted the code while refactoring.

@Lestropie Lestropie self-assigned this Oct 5, 2025
@jdtournier jdtournier changed the title mrview: Bugfix in rendering of cobes in connectome tool mrview: Bugfix in rendering of cubes in connectome tool Oct 8, 2025
@Lestropie
Copy link
Member Author

Member variable num_indices is read here. So prior to this change, there is presumably a buffer overrun happening, but only on the GPU. Neither gdb nor valgrind catch anything, and the visualisation looks correct in both cases.

@Lestropie Lestropie added this pull request to the merge queue Oct 9, 2025
Merged via the queue into master with commit af3846c Oct 9, 2025
5 checks passed
@Lestropie Lestropie deleted the mrview_cube_fix branch October 9, 2025 04:18
@jdtournier jdtournier mentioned this pull request Oct 20, 2025
Lestropie added a commit that referenced this pull request Jan 12, 2026
Pull Requests that required manual code porting due to incompatibility of code bases between master and dev:
- #3148
- #3107
- #3181
- #3207
- #3195
- #3197
- #3205
- #3187
- #3050
- #3204
- #3215
- #3172
- #3233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants