Fix packaging workflows on master#3086
Conversation
- Use Github Action to setup miniconda - Hardode repo name for packaging script
- Install MSYS2 environment using Github Action - Remove qtbinpatcher step
New standard for pacman now uses zstd rather than .tar.xz
Lestropie
left a comment
Lestropie
left a comment
There was a problem hiding this comment.
Very difficult one to review. Technically could look at the results you obtained on your fork, but I'm trusting that you've verified everything as well as can be. It's probably a matter of re-verifying as we generate the tag and correcting anything that comes up before announcing that the version is available. So if you're content yourself, I'm content to merge whenever you see fit.
|
Further testing of the MacOS native workflow (the only one I couldn't verify because of the reason mentioned above) seems to show some problems:
So will need to solve this before merging, will convert this PR to draft until these issues are solved. |
The macOS bundled python version should be in the default PATH, no? Is this not a python2 vs python3 issue? As far as I know python3 should be in the default PATH. The main reason I reset the PATH to the bare macOS path is to make sure we only rely on OS-bundled libs and do not accidentally use third party libs (from homebrew, cmake installations, custom python installs, etc), which can’t be relied on for a binary installer. |
Sorry, yes that's correct. However, we can't create a symlink in |
We symlink /usr/bin/python3 in $PWD/python_dir and pass this folder as an extra path to the build script. This allows MRtrix3's build and configure script to use Python3 to build the project.
To build universal binaries with MacOS we need at least Qt 5.15.9
|
I have now updated the MacOS build script to support the building of universal binaries. To do this, I have upgraded the Qt version to 5.15.16 (the support for building universal binaries was introduced in version 5.15.9). I have tested the script locally and also using a test workflow on GitHub Actions. It seems to produce the expected results. I think this can now be merged. |
4 participants
This PR fixes all of our packaging workflows in preparation for the 3.0.5 release. Main changes:
devto set up an MSYS2 environment (MINGW64 instead of UCRT64 for compatibility reasons). Additionally, an explicit addition of-lopengl32linker flag has been made (otherwise the build was failing).minicondaenvironment.condaandpacman).Since GitHub Actions are painful to debug, I tested these on a separate fork of MRtrix3. The workflows seem to produce the expected results with the exception of the MacOS native build script, which is configured to directly clone and build the MRtrix3 repo (the release tag that triggers the workflow must be present in the MRtrix3 official repo). We should probably do a test release to check that all of them work as intended.
Closes #3007.