Skip to content

Fix tck writer when a single streamline exceed the buffer size#3071

Merged
Lestropie merged 1 commit intomasterfrom
fix_tck_writer_large_streamline
Mar 14, 2025
Merged

Fix tck writer when a single streamline exceed the buffer size#3071
Lestropie merged 1 commit intomasterfrom
fix_tck_writer_large_streamline

Conversation

@jdtournier
Copy link
Member

This addresses an issue raised on the forum, and is due to our use of a write-back buffer (to prevent file segmentation) with a default size of 16MB. This is ample for regular streamlines, but clearly not enough in all cases...

Original issue:
https://community.mrtrix.org/t/tckgen-seed-point-visualization/8271/2

This addresses an issue raised on the forum, and is due to our use of a
write-back buffer (to prevent file segmentation) with a default size of
16MB. This is ample for regular streamlines, but clearly not enough in
all cases...

Original issue:
https://community.mrtrix.org/t/tckgen-seed-point-visualization/8271/2
@jdtournier jdtournier added the bug label Mar 10, 2025
@jdtournier jdtournier requested a review from a team March 10, 2025 16:09
Copy link
Member

@Lestropie Lestropie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lestropie Lestropie added this pull request to the merge queue Mar 13, 2025
Merged via the queue into master with commit 70da007 Mar 14, 2025
5 checks passed
@Lestropie Lestropie deleted the fix_tck_writer_large_streamline branch March 14, 2025 00:02
@Lestropie Lestropie mentioned this pull request Sep 2, 2025
Lestropie added a commit that referenced this pull request Sep 3, 2025
- #2968: Absent
- #3049: Absent
- #2767: Partially absent
- # 3027: Almost all absent (the new tests were in place but that was all)
- #3047: Absent
- #3071: Absent
- #3011: Fill in gaps of changes that were applied to #3011 prior to its derivation from #2917.
- #2609: Fixed a couple of small omissions.
- #2602: Bits and pieces missing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants