Closed
Conversation
Lestropie
added a commit
that referenced
this pull request
Mar 11, 2025
Some command-line arguments could be one of multiple types, depending on the user's desired input / behaviour. Rather than simply flagging all such instances as "various", thereby placing zero restrictions on inputs and providing minimal information on the interface internally, instead utilise each command-line argument type as a bitwise flag, allowing each command-line argument to nominate what types of input are allowed vs. not. Note that this requires some care internally within the command-line parsing: requirements at the point of command-line parsing can typically only be imposed if the argument type is exclusive. Also fixes some non-functional checks on the CLIs, which neglected to detect expected deviations from previous behaviour. Closes #2580. Supersedes #3067.
Member
Author
|
Superseded by #3074. |
Lestropie
added a commit
that referenced
this pull request
Aug 26, 2025
Some command-line arguments could be one of multiple types, depending on the user's desired input / behaviour. Rather than simply flagging all such instances as "various", thereby placing zero restrictions on inputs and providing minimal information on the interface internally, instead utilise each command-line argument type as a bitwise flag, allowing each command-line argument to nominate what types of input are allowed vs. not. Note that this requires some care internally within the command-line parsing: requirements at the point of command-line parsing can typically only be imposed if the argument type is exclusive. Also fixes some non-functional checks on the CLIs, which neglected to detect expected deviations from previous behaviour. Closes #2580. Supersedes #3067.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downstream of #2911.
Found that when transitioning a command-line option from a fixed type to a
.type_various(), I got an error relating to attempting to resolve a bad variant. Seems my CLI tests were not comprehensive enough to catch; I might look at expanding that before merging.#2580 would fix this problem, as each individual possible type would have its own limits data instantiated.