tcksift2: Minor fixes to diagnosis data#3050
Merged
jdtournier merged 2 commits intomasterfrom Oct 8, 2025
Merged
Conversation
The current DWI::Fixel_map<> class (to be deprecated in the future) contains at index 0 a fixel with an empty constructor. Any diagnosis information presented to the user should therefore be computed without consideration for this non-existing fixel.
Lestropie
force-pushed
the
sift_null_fixel
branch
2 times, most recently
from
f41cb8f to
5ecf24b
Compare
jdtournier
approved these changes
Oct 8, 2025
Merged
Lestropie
added a commit
that referenced
this pull request
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
DWI::Fixel_map<>class (to be deprecated in the future) contains at index 0 a fixel with an empty constructor. Any diagnosis information presented to the user should therefore be computed without consideration for this non-existing fixel.Reported by @ppruc.