dwi2tensor: Preserve dw_scheme for -predicted_signal#2955
Merged
Conversation
Preserving the diffusion gradient scheme in the image header for the output of the -predicted_signal option is preferable for enabling visualisation of such data using the MRView ODF Tool in Dixel mode.
bjeurissen
approved these changes
Nov 20, 2024
31 tasks
Lestropie
added a commit
that referenced
this pull request
Jan 15, 2025
Resolution of content merged to dev initially omitted from #3061. - #2693 (completely omitted) - #3005 (partial propagation / independent address of some common issues on both branches) - #3001 (completely omitted) - #2908 (completely omitted) - #2955 (completely omitted) - #2600 (completely omitted) - #2962 (completely omitted) - #2935 (completely omitted) - #2923 (completely omitted) - #2910 (completely omitted) - #2638 (completely omitted) - #2698 (completely omitted) - #2721 (completely omitted) - #2794 (completely omitted) - #2768 (completely omitted; required modification to conform to other dev changes) - #2713 (residual compilation errors following adf8fdd, including resolution against changes in #2437 on dev.
Lestropie
added a commit
that referenced
this pull request
Jan 15, 2025
Resolution of content merged to dev initially omitted from #3061. - #2693 (completely omitted) - #3005 (partial propagation / independent address of some common issues on both branches) - #3001 (completely omitted) - #2908 (completely omitted) - #2955 (completely omitted) - #2600 (completely omitted) - #2962 (completely omitted) - #2935 (completely omitted) - #2923 (completely omitted) - #2910 (completely omitted) - #2638 (completely omitted) - #2698 (completely omitted) - #2721 (completely omitted) - #2794 (completely omitted) - #2768 (completely omitted; required modification to conform to other dev changes) - #2713 (residual compilation errors following adf8fdd, including resolution against changes in #2437 on dev.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the output of
dwi2tensor -predicted_signalcan't be loaded in themrviewODF tool, asdw_schemeis shashed toprior_dw_scheme. This change ensures thatdw_schemeremains present in the output of the-predicted_signaloption, but is stashed for all other outputs.