Deprecated distutils module in Python 3.12#2948
Merged
Conversation
daljit46
previously approved these changes
Jul 29, 2024
For 3.0.x, alias shutil.which() as find_executable(); load distutils.find_executable() as itself on Python 2. Reverts and replaces fcf0ba9, which had erroneous indentation.
daljit46
approved these changes
Jul 30, 2024
31 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix is exclusively for
master/ 3.0.x, to support Python 3.12 whilst preserving Python2 support. Ondev, Python2 support has been dropped, andshutil.which()is used by name../run_tests scriptssuccessful.Can't fully verify via CI as Python2 support is not explicitly tested. No particular interest in doing so either; would prefer to focus on testing the range of Python3 versions supported (#2821) for 3.1. So hopefully this can be reviewed from first principles.