You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Addresses #2826.
Testing tips and instructions have been updated to reflect the transition to CMake. Sections on the handling of testing data assume #2848 has been merged.
Some instructions may not be clear or need removing due to the fact that some of the concerns/workflows no longer apply with the transition to CMake.
I've updated the testing instructions to reflect the latest changes in testing code. @Lestropie could you please have a look and see if there's anything that's missing and/or incorrect?
The later text read like it was written when we first added the testing. I've replaced it with something new describing how I typically go about it these days.
I think you've removed the section on using a local clone to download the test data. Shall we omit that in the testing readme? I think it'd be for that mechanism to be documented somewhere at least.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
daljit46
force-pushed
the
update_testing_readme
branch
from
Addresses #2826.
Testing tips and instructions have been updated to reflect the transition to CMake. Sections on the handling of testing data assume #2848 has been merged.
Some instructions may not be clear or need removing due to the fact that some of the concerns/workflows no longer apply with the transition to CMake.
It's still WIP.