Conversation
Initial contents of this file included in this commit are taken directly from #2154.
|
clang-tidy review says "All clean, LGTM! 👍" |
|
@daljit46 Open to feedback on how to best achieve this, given I'd like to combine it with #2821 before merging #2678. Previously, this was slated to be achieved by adding an extra text file, which could be specified as the input argument to (On reading for the first time I also wonder if using labels to separate between C++ command / Python command / unit tests would be better than grepping on test names?) |
|
If this suite of tests is under the category of "scripts", then I think it would make sense to place this under If we want to create a subset of an existing set of tests, then I think we need a way to parse a "label" for a test from a text file. Something like a comment or another syntax that tells us the specific label of the test. Then, we can easily run a specific set of test matching a label. |
|
Given dc3566f in #2865 lists each test explicitly for |
Creating a new PR to deprecate #2154 given the incompatibility of some of those differences with a
cmake-baseddev.At initial posting, this just includes a single text file.
CI: Perform limited script testing #2154 kind of hacked its way into providing this test in terms of setting the data location / working directory. I doubt that just dumping this file in its current location will work, since it needs to (obtain and) set its location to the script data directory.
Obviously will need to look at its total runtime to see if it's prohibitive to include as part of CI.
Edit: Evaluating this set of tests within a Python 3.7 environment could kill two birds with one stone (Test Python 3.7 compatibility #2821).