Conversation
…ith unsupported transfer syntax This at least allow mrinfo to run. Any operation that attempts to access the voxel data will of course fail.
Co-authored-by: Robert Smith <[email protected]>
|
For info: the motivation for this is to at least allow |
Lestropie
left a comment
There was a problem hiding this comment.
I had wanted to test this on some local data with unsupported transfer syntax, but am now having trouble finding any. I do plan on generating some at some point using the local scanner in order to evaluate scope of current support and prospect of better support (eg. #2675) and to augment the testing suite, but have not yet found the time to do it.
I nevertheless checked the code at the time and was happy with it (over and above aef44bb). Only other thing to consider would be version-matching the documentation hyperlink, but that's not requisite for the PR.
|
Actually, in retrospect, the documentation shows |
|
Found some unsupported data. Works as intended at my end, though the user feedback is perhaps sub-optimal:
|
…read_with_unsupported_transfer_syntax
|
This requires review by someone other than myself or @jdtournier as we can't approve our own changes to |
…read_with_unsupported_transfer_syntax
- #2968: Absent - #3049: Absent - #2767: Partially absent - # 3027: Almost all absent (the new tests were in place but that was all) - #3047: Absent - #3071: Absent - #3011: Fill in gaps of changes that were applied to #3011 prior to its derivation from #2917. - #2609: Fixed a couple of small omissions. - #2602: Bits and pieces missing.
This at least allow mrinfo to run. Any operation that attempts to access the voxel data will of course fail.