PNG export: Exception on too few axes#2535
Merged
jdtournier merged 2 commits intomasterfrom Dec 7, 2022
Merged
Conversation
Member
Author
|
Should also note that unlike #2465 this is better guaranteed to not change behaviour on |
jdtournier
approved these changes
Dec 7, 2022
Member
jdtournier
left a comment
jdtournier
left a comment
There was a problem hiding this comment.
Seems to catch the problematic usage on my system. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #2465.
This section of code is also relevant to #2179.
As described in this comment, the usage resulting in a segfault is likely not that intended. But further, attempting to save to
out-[].pngfrom a 1 x 128 x 128 image could (theoretically at least) yield either a single 128 x 128 image (effectively "ignoring" the square-bracket syntax), or, more faithfully, 128 different 1 x 128 images. Presence of unity axes is already used within the PNG handling to identify the slice orientation to use for PNG files.For now, this comment instead catches the likely erroneous but also potentially ambiguous usage and errors out, rather than segfaulting. Later, hopefully for
3.1.0, I'll try to restructure the relevant code in order to address #2179, and hopefully if the code is better structured the right solution in this instance will fall out.