PNG: handle single sagittal or coronal slices correctly#2465
PNG: handle single sagittal or coronal slices correctly#2465jdtournier wants to merge 1 commit intomasterfrom
Conversation
|
PR fails existing binary test. Being an intrinsically 2D format, there is a more complex relationship between the nature of the input data and the utilisation of square-bracket notation in the output path for PNG. I'll have to remind myself of how it works and then figure out why this edge use case fails. |
|
Need to clarify the intended behaviour in this circumstance. If But you're then specifying an output image path with the square-bracket syntax. This would logically take the last non-unity axis---the third axis in this case---and generate one PNG file per coordinate, resulting in 128 images of dimension 1x128. Suspect that this is not what the user intended, but it should nevertheless work rather than segfaulting. I don't think it makes sense that the square-bracket syntax would detect a unity dimension and "attach itself" to that dimension given that by its very nature it's intended to write multiple image files. |
|
Proposed that this be deferred from |
|
Closing in favour of #2535. |
Came across this while answering a question on the forum. On current
master, this happens:Or alternatively:
Basically any attempt to convert a single sagittal or coronal slice using the square bracket syntax. Works OK if output file is simply
out.png(not using square bracket syntax). Also works OK if selecting a single axial slice.Changes in the PR seem to fix the problem.