dwi2response manual: avoid checking and calculating a brain mask#2373
dwi2response manual: avoid checking and calculating a brain mask#2373
Conversation
For the manual response function estimation, a brain mask is not needed or supported. However, currently, a brain mask is always calculated if one is not provided. This is unnecessary and can also lead to crashes whenever dwi2mask fails (e.g. exotic data, simulations, ... exactly the use-cases where you would use manual response estimation).
|
Not sure why building fails on macos, as I did not make any changes to the C++ code. Looks like we would need b379fc8 after all? |
|
Testing string equivalence of the selected algorithm within |
…it supports a mask
Agreed! Latest commit should fix that. |
jdtournier
left a comment
jdtournier
left a comment
There was a problem hiding this comment.
Seems OK to me. Ready to merge, @Lestropie?
3 participants
For the manual response function estimation, a brain mask is not needed or supported. However, currently, a brain mask is always calculated if one is not provided. This is unnecessary and can also lead to crashes whenever dwi2mask fails (e.g. exotic data, simulations, ... exactly the use-cases where you would use manual response estimation).