Conversation
In instances where the input data contain non-finite values (regardless of whether or not such data are excluded from statistical inference via a mask), and at least one F-test is performed, writing the absolute and standardised effect size as NaN (as such cannot be meaningfully calculated for an F-test) was incorrectly indexed, leading to a segmentation fault.
jdtournier
left a comment
jdtournier
left a comment
There was a problem hiding this comment.
I'm not sure I fully appreciate what each row of your local_abs_effect_size and local_std_effect_size is supposed to contain, but I'll take your word for it that it's appropriate to set the first row to NaN rather than the second... 😁
In cases where the GLM can't be fit to the exhaustive set of data in a single matrix operation, the relevant code loops over elements, each thread processes one element at a time. So any GLM derivative that would normally have one row per element becomes a row vector in that context. But they're treated as matrices with one row rather than explicit vectors so that the same function can be used as that used when all data are solved at once. |
2 participants
As reported in #2289.
Fixes segmentation fault in case where:
-columnoption;Fairly obvious blunder even without explaining the surrounding code.