fod2fixel: Wipe transform / spacing info from fixel data files#2285
Merged
fod2fixel: Wipe transform / spacing info from fixel data files#2285
Conversation
jdtournier
approved these changes
Feb 10, 2021
Member
jdtournier
left a comment
jdtournier
left a comment
There was a problem hiding this comment.
Looks like you might need to update the testing data though...
Lestropie
added a commit
to MRtrix3/test_data
that referenced
this pull request
Feb 10, 2021
Set identity transform and voxel sizes to 1mm as per MRtrix3/mrtrix3#2285.
Member
Author
|
New test data generated by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As raised on forum.
I had in 61bfc64 prevented non-identity transform / voxel spacing info from being written to fixel data files, but only in the helper function
data_header_from_index(), whereasfod2fixeldoes this same process manually.