tckglobal: Fix bug that caused particles in a voxel to be duplicated when tried to be removed#2257
Merged
dchristiaens merged 2 commits intoMRtrix3:masterfrom Jan 13, 2021
Conversation
Rebase to latest master
Use erase-remove idiom, otherwise particles will be duplicated instead of removed.
sertopexamgio
changed the title
sertopexamgio
changed the title
sertopexamgio
changed the title
dchristiaens
approved these changes
Jan 13, 2021
Member
dchristiaens
left a comment
dchristiaens
left a comment
There was a problem hiding this comment.
Very good catch, and thanks for contributing!
This is clearly a bug, which I seem to have introduced 4 years ago. I tested your fix and it works exactly as it should.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I observed particles inside a voxel getting duplicated after the ParticleGrid::remove and ParticleGrid::shift. After some digging, the reason seem to be the erase-delete-idiom. After these changes, no duplicates of particles were observed and removal of shifting seems to work as expected.