mrview: fix handling of -focus and -target options#2250
Merged
jdtournier merged 7 commits intomasterfrom Jan 20, 2021
Merged
Conversation
- The -focus option was not labelled as type_sequence_float(), leading to
a warning if the first value is negative, e.g.:
mrview: [WARNING] Value "-1,2,3" is being used as the expected argument
for option "-focus"; is this what you intended?
- It should be allowed to use the -target option multiple times.
Lestropie
requested changes
Jan 11, 2021
Member
Lestropie
left a comment
Lestropie
left a comment
There was a problem hiding this comment.
Given that -focus can be either a floating-point sequence or a boolean, it would be better flagged as .type_various(). That will still remove the erroneous warning if the first character of the provided argument is a dash.
Member
Author
I guess you learn something new every day... 👍 |
Lestropie
approved these changes
Jan 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
-focusoption was not labelled as type_sequence_float(), leading toa warning if the first value is negative, e.g.:
It should be allowed to use the
-targetoption multiple times.