Skip to content

python: fix handling of N/A output in image.statistics()#2249

Merged
jdtournier merged 2 commits intomasterfrom
fix_NA_handling_in_image_statistics_parsing
Jan 20, 2021
Merged

python: fix handling of N/A output in image.statistics()#2249
jdtournier merged 2 commits intomasterfrom
fix_NA_handling_in_image_statistics_parsing

Conversation

@jdtournier
Copy link
Member

@jdtournier jdtournier commented Jan 6, 2021 •
edited
Loading

Discussed in #2248

I consider this a bug fix, but I suggest merging to dev given there is scope for this to change behaviour of existing apps. Up for discussion.

@jdtournier jdtournier added this to the 3.0.3 hotfix milestone Jan 6, 2021
@jdtournier jdtournier requested a review from Lestropie January 6, 2021 12:37
@jdtournier jdtournier self-assigned this Jan 6, 2021
@jdtournier jdtournier modified the milestones: 3.0.3 hotfix, 3.1.0 updates Jan 6, 2021
Lestropie
Lestropie requested changes Jan 11, 2021
View reviewed changes
Copy link
Member

@Lestropie Lestropie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer to do the copyright message update in its own PR so that it doesn't corrupt the diff of unrelated changes. It looks like other stuff unrelated to the topic at hand has also made its way into here, likely due to a difference in base between the local branch and the PR, which would also make more sense in its own PR.

I consider this a bug fix, but I suggest merging to dev given there is scope for this to change behaviour of existing apps.

If the only "change of behaviour" is provision of a more interpretable error message where continuation of processing is not possible in any case, I don't think that merging to master is a problem.

@jdtournier
Copy link
Member Author

jdtournier commented Jan 11, 2021

Fair enough to split it from the changes in master. I'll clean this up once #2255 is merged.

I consider this a bug fix, but I suggest merging to dev given there is scope for this to change behaviour of existing apps.

If the only "change of behaviour" is provision of a more interpretable error message where continuation of processing is not possible in any case, I don't think that merging to master is a problem.

Well, in the case of dwi2response, I assume processing would stop in any case. But there may be other cases where a single-voxel mask would have caused a failure prior to these changes, but would complete successfully now. But if that's the case, I would agree that these would still nonetheless class as bug fixes. So I'll rebase it onto master as you suggest.

@jdtournier jdtournier force-pushed the fix_NA_handling_in_image_statistics_parsing branch from 26c0cf9 to d19f3b4 Compare January 11, 2021 16:20
@jdtournier jdtournier changed the base branch from dev to master January 11, 2021 16:20
@jdtournier jdtournier modified the milestones: 3.1.0 updates, 3.0.3 hotfix Jan 11, 2021
@jdtournier jdtournier merged commit e2274ef into master Jan 20, 2021
@jdtournier jdtournier deleted the fix_NA_handling_in_image_statistics_parsing branch January 20, 2021 14:17
@Lestropie Lestropie modified the milestones: 3.0.4 hotfix, 3.0.3 hotfix May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lestropie Lestropie Lestropie approved these changes

Assignees

@jdtournier jdtournier

Labels

None yet

Projects

None yet

Milestone

3.0.3 hotfix

Development

Successfully merging this pull request may close these issues.

2 participants

@jdtournier @Lestropie