Conversation
When voxels contain a partial volume fraction that does not lie within the range [0.0, 1.0], do not immediately throw an Exception. Instead, include those voxels in the output mask image (if requested), report the number of voxels with such an issue, and only then throw the Exception. Also rename command-line option "-mask" to "-voxels", since "-mask" typically refers to an input, whereas dwi2response sets the precedent for -voxels.
Left over from experimenting when looking for issues with a specific dataset.
Lestropie
added a commit
that referenced
this pull request
Jan 28, 2020
Due to #1909 and #1915, 5ttcheck will not throw an Exception if there are image values that do not lie within the [0.0, 1.0] range. This includes the current version of test data. Rather than correspondingly causing dwi2response msmt_5tt to fail, instead catch the run.MRtrixCmdError, and print the message to the terminal at warning level as previously.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhancement of #1909.