Skip to content

UX Overhaul, add user guide#135

Closed
kartikcho wants to merge 6 commits into
masterfrom
UX-overhaul
Closed

UX Overhaul, add user guide#135
kartikcho wants to merge 6 commits into
masterfrom
UX-overhaul

Conversation

@kartikcho

Copy link
Copy Markdown
Member

Resolves #125

Changes made in this PR

  • Add loading spinner when a profile is being processed (the app used to freeze the tab with no visual feedback about loading earlier).
  • Add a modal explaining the profiler's different elements, events and a legend key about the event colors.
  • Slightly changed landing content.

Screenshots:

image

image

We should update the explanations if they're not clear enough.
Also, the legend keys look out of place in my opinion, we should think of a better layout. Maybe add another image explaining resize bar and scroll?

@vercel

vercel Bot commented Aug 17, 2020

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mlh-fellowship/scheduling-profiler-prototype/qctzjq752
✅ Preview: https://scheduling-profiler-prototype-git-ux-overhaul.mlh-fellowship.vercel.app

@kartikcho
kartikcho requested a review from taneliang August 17, 2020 07:46
@kartikcho

Copy link
Copy Markdown
Member Author

What do you think about using labelled images like below?

lanes

@taneliang

Copy link
Copy Markdown
Member

Cool! First impressions:

legend keys look out of place in my opinion

Yep, I agree

What do you think about using labelled images like below?

That looks okay, but we need to explain what React measures are

@kartikcho

Copy link
Copy Markdown
Member Author

Could we left-align the text instead?

Sure

The text animates in 2 phases

It's because of the 'lazy' transition when overlay is loaded, not really an issue.

Could we move the images above the text in those situations?

Changed layout to single column, removed event legend key, moved images below text though.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve UX, add user guide for new users

2 participants