powerpc: use IRQF_NO_DEBUG for IPIs

legoater · Fox Snowpatch · commit 807e00009192 · 2021-07-19T17:55:48.000Z
There is no need to use the lockup detector ("noirqdebug") for IPIs.
The ipistorm benchmark measures a ~10% improvement on high systems
when this flag is set.

Cc: Thomas Gleixner &lt;tglx@linutronix.de&gt;
Signed-off-by: Cédric Le Goater &lt;clg@kaod.org&gt;
diff --git a/arch/powerpc/sysdev/xics/xics-common.c b/arch/powerpc/sysdev/xics/xics-common.c
@@ -133,7 +133,7 @@ static void xics_request_ipi(void)
 	 * IPIs are marked IRQF_PERCPU. The handler was set in map.
 	 */
 	BUG_ON(request_irq(ipi, icp_ops->ipi_action,
-			   IRQF_PERCPU | IRQF_NO_THREAD, "IPI", NULL));
+			   IRQF_NO_DEBUG | IRQF_PERCPU | IRQF_NO_THREAD, "IPI", NULL));
 }
 
 void __init xics_smp_probe(void)
diff --git a/arch/powerpc/sysdev/xive/common.c b/arch/powerpc/sysdev/xive/common.c
@@ -1161,7 +1161,8 @@ static int __init xive_request_ipi(void)
 		snprintf(xid->name, sizeof(xid->name), "IPI-%d", node);
 
 		ret = request_irq(xid->irq, xive_muxed_ipi_action,
-				  IRQF_PERCPU | IRQF_NO_THREAD, xid->name, NULL);
+				  IRQF_NO_DEBUG | IRQF_PERCPU | IRQF_NO_THREAD,
+				  xid->name, NULL);
 
 		WARN(ret < 0, "Failed to request IPI %d: %d\n", xid->irq, ret);
 	}

Original file line number	Diff line number	Diff line change
`@@ -133,7 +133,7 @@ static void xics_request_ipi(void)`
`133`	`133`	`* IPIs are marked IRQF_PERCPU. The handler was set in map.`
`134`	`134`	`*/`
`135`	`135`	`BUG_ON(request_irq(ipi, icp_ops->ipi_action,`
`136`		`- IRQF_PERCPU \| IRQF_NO_THREAD, "IPI", NULL));`
	`136`	`+ IRQF_NO_DEBUG \| IRQF_PERCPU \| IRQF_NO_THREAD, "IPI", NULL));`
`137`	`137`	`}`
`138`	`138`
`139`	`139`	`void __init xics_smp_probe(void)`
Original file line number	Diff line number	Diff line change
`@@ -1161,7 +1161,8 @@ static int __init xive_request_ipi(void)`
`1161`	`1161`	`snprintf(xid->name, sizeof(xid->name), "IPI-%d", node);`
`1162`	`1162`
`1163`	`1163`	`ret = request_irq(xid->irq, xive_muxed_ipi_action,`
`1164`		`- IRQF_PERCPU \| IRQF_NO_THREAD, xid->name, NULL);`
	`1164`	`+ IRQF_NO_DEBUG \| IRQF_PERCPU \| IRQF_NO_THREAD,`
	`1165`	`+ xid->name, NULL);`
`1165`	`1166`
`1166`	`1167`	`WARN(ret < 0, "Failed to request IPI %d: %d\n", xid->irq, ret);`
`1167`	`1168`	`}`