Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the automatic external URL fetching functionality that was previously added to the adapter system. The revert restores compatibility by making createUIResource synchronous-only again and removing the feature that automatically converted externalUrl resources to rawHtml when adapters were enabled.
Key Changes
- Removed the
fetchExternalUrlAsRawHtmlutility function that enabled automatic URL fetching - Reverted
createUIResourcefrom returningUIResource | Promise<UIResource>to returning onlyUIResource - Removed the
external-url-adapterexample demonstrating the reverted feature
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
sdks/typescript/server/src/utils.ts |
Removed fetchExternalUrlAsRawHtml function (130 lines) that handled external URL fetching, base tag injection, and CSP meta tag removal |
sdks/typescript/server/src/index.ts |
Removed async external URL handling logic from createUIResource and reverted function signature to synchronous-only; removed import of deleted function |
sdks/typescript/server/src/adapters/mcp-apps/README.md |
Removed documentation section explaining external URL adapter functionality and async behavior |
sdks/typescript/server/src/__tests__/adapters/adapter-integration.test.ts |
Removed test imports (vi, beforeEach, afterEach); updated tests to verify external URLs are not wrapped with adapters; removed 387 lines of tests for external URL fetching functionality |
sdks/typescript/server/README.md |
Removed documentation section explaining external URL adapter functionality and async behavior |
examples/external-url-adapter/tsconfig.json |
Deleted entire TypeScript configuration file as part of example removal |
examples/external-url-adapter/src/index.ts |
Deleted entire example server implementation (303 lines) demonstrating external URL adapter functionality |
examples/external-url-adapter/package.json |
Deleted package configuration file as part of example removal |
examples/external-url-adapter/README.md |
Deleted example documentation (155 lines) explaining external URL adapter feature |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 8, 2025
…er/v5.16.2) (2025-12-08) ### Bug Fixes * revert externalUrl adapter for compatibility ([#159](#159)) ([3c5289a](3c5289a))
github-actions bot
pushed a commit
that referenced
this pull request
Dec 18, 2025
…/v5.17.1...client/v5.18.0-alpha.1) (2025-12-18) ### Bug Fixes * **client:** use type-only imports for @modelcontextprotocol/sdk types ([#157](#157)) ([d84cb3e](d84cb3e)) * revert externalUrl adapter for compatibility ([#159](#159)) ([3c5289a](3c5289a)) * trigger TS release ([e28d1f6](e28d1f6)) * update adapter to latest MCP Apps spec ([#163](#163)) ([e342034](e342034)) * update MCP Apps adapter mimetype ([#162](#162)) ([c91e533](c91e533)) * update ui/message to pass an array ([#167](#167)) ([80cf222](80cf222)) ### Features * **client:** expose MCP request handlers and AppBridge ref ([3cf3c37](3cf3c37)) * **client:** make Client optional with onReadResource alternative ([fece80e](fece80e)) * use ext-apps branch with setter-based MCP forwarding handlers ([a312e52](a312e52))
|
🎉 This PR is included in version 5.18.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 20, 2025
…nt/v5.17.2) (2025-12-20) ### Bug Fixes * **client:** use type-only imports for @modelcontextprotocol/sdk types ([#157](#157)) ([d84cb3e](d84cb3e)) * revert externalUrl adapter for compatibility ([#159](#159)) ([3c5289a](3c5289a)) * trigger TS release ([e28d1f6](e28d1f6)) * update adapter to latest MCP Apps spec ([#163](#163)) ([e342034](e342034)) * update MCP Apps adapter mimetype ([#162](#162)) ([c91e533](c91e533)) * update ui/message to pass an array ([#167](#167)) ([80cf222](80cf222))
|
🎉 This PR is included in version 5.17.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
katherinek727
added a commit
to katherinek727/mcp-ui
that referenced
this pull request
Feb 28, 2026
…ver/v5.16.1...server/v5.16.2) (2025-12-08) ### Bug Fixes * revert externalUrl adapter for compatibility ([#159](MCP-UI-Org/mcp-ui#159)) ([7a855e2](MCP-UI-Org/mcp-ui@7a855e2))
katherinek727
added a commit
to katherinek727/mcp-ui
that referenced
this pull request
Feb 28, 2026
…ent/v5.17.1...client/v5.17.2) (2025-12-20) ### Bug Fixes * **client:** use type-only imports for @modelcontextprotocol/sdk types ([#157](MCP-UI-Org/mcp-ui#157)) ([4ece399](MCP-UI-Org/mcp-ui@4ece399)) * revert externalUrl adapter for compatibility ([#159](MCP-UI-Org/mcp-ui#159)) ([7a855e2](MCP-UI-Org/mcp-ui@7a855e2)) * trigger TS release ([fc8a053](MCP-UI-Org/mcp-ui@fc8a053)) * update adapter to latest MCP Apps spec ([#163](MCP-UI-Org/mcp-ui#163)) ([819cf59](MCP-UI-Org/mcp-ui@819cf59)) * update MCP Apps adapter mimetype ([#162](MCP-UI-Org/mcp-ui#162)) ([e99b306](MCP-UI-Org/mcp-ui@e99b306)) * update ui/message to pass an array ([#167](MCP-UI-Org/mcp-ui#167)) ([ba8afa7](MCP-UI-Org/mcp-ui@ba8afa7))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes externalUrl adapter that caused a breaking change.
It'll be reintroduced as a new major once sandbox CSP negotiation is standardized.