Potential fix for code scanning alert no. 2: Useless regular-expression character escape#33
Merged
Merged
Conversation
…on character escape Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
dev-Ninjaa
commented
Feb 17, 2026
dev-Ninjaa
left a comment
dev-Ninjaa
left a comment
Member
Author
There was a problem hiding this comment.
The fix is to remove unnecessary backslashes before characters that do not need escaping in this context, ensuring the regex semantics remain unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Luxion-Labs/PulmNotes/security/code-scanning/2
In general, the fix is to remove unnecessary backslashes before characters that do not need escaping in this context, ensuring the regex semantics remain unchanged. Here, the
\-sequences appear inside character classes where-is already interpreted as a literal dash due to its position (between other characters, not creating a range). Therefore, the safest and simplest fix is to replace\-with-in the character classes.Concretely, in
editor/lib/tiptap-utils.tsat line 469, the pattern:`^(?:(?:${allowedProtocols.join("|")}):|[^a-z]|[a-z0-9+.\-]+(?:[^a-z+.\-:]|$))`should be updated so that
\-becomes-in both character classes. The resulting regex template string will be:`^(?:(?:${allowedProtocols.join("|")}):|[^a-z]|[a-z0-9+.-]+(?:[^a-z+.:-]|$))`This keeps the behavior the same (matching alphanumerics, plus, dot, hyphen, etc.) while removing useless escapes. No new methods, imports, or definitions are needed elsewhere in the file.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.