Potential fix for code scanning alert no. 1: Incomplete URL substring sanitization#32
Merged
Conversation
… sanitization Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Luxion-Labs/PulmNotes/security/code-scanning/1
In general, the fix is to stop checking for
placeholder.comorpicsum.photoson the entire URL string and instead parse the URL and inspect only its host, ensuring that those domain names actually appear in the hostname (and not in query/path), and in a controlled way (e.g., exact match or well-defined subdomains). This avoids situations where an arbitrary host embeds the substring in a non-host component.For this specific code, the minimal, behavior‑preserving change is:
urlwith the standardURLconstructor (available in modern Node and browsers) in a small helper that safely returnsnullon invalid input.parsed.hostname) and compare against a small whitelist of allowed image hostnames (picsum.photos,www.picsum.photos,placeholder.com,www.placeholder.com).url.includes('picsum.photos') || url.includes('placeholder.com')with calls to this hostname‑based check.To implement this, within
app/lib/richContentParser.ts:Add a helper function
getHostname(url: string): string | nullnear the bottom of the file (for example, afterextractVimeoId) that usesnew URL(url)and catches errors.In the image detection condition at line 45, compute
const host = getHostname(url);and adjust the condition to:hostis in a small array of allowed image hosts.No new imports are strictly required since
URLis globally available in modern Node.js and browsers; if this code runs in such an environment, we can rely on it directly.Suggested fixes powered by Copilot Autofix. Review carefully before merging.